Closed
Bug 1348562
Opened 7 years ago
Closed 7 years ago
Unreferenced files in chrome://devtools/skin/images/
Categories
(DevTools :: General, enhancement, P1)
DevTools
General
Tracking
(firefox55 fixed)
RESOLVED
FIXED
Firefox 55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: florian, Assigned: jryans)
References
Details
Attachments
(1 file)
I don't see any reference in the code to the following chrome files: chrome://devtools/skin/images/fast-forward.svg chrome://devtools/skin/images/firebug/spinner.png chrome://devtools/skin/images/noise.png
Reporter | ||
Comment 1•7 years ago
|
||
Missed this one: chrome://devtools/skin/images/debugging-devices.svg
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Priority: -- → P1
Comment hidden (mozreview-request) |
Assignee | ||
Comment 3•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f4266dd448d6749d67476ac21d6a440ffc751e90
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8849633 [details] Bug 1348562 - Remove unreferenced DevTools images. https://reviewboard.mozilla.org/r/122426/#review124884 Thank you for removing these unused images Ryan!
Attachment #8849633 -
Flags: review?(pbrosset) → review+
Reporter | ||
Comment 5•7 years ago
|
||
Thanks for cleaning this up! (In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #3) > https://treeherder.mozilla.org/#/ > jobs?repo=try&revision=f4266dd448d6749d67476ac21d6a440ffc751e90 I'm surprised my browser_all_files_referenced.js test didn't fail on this try run, maybe your tree didn't have it yet. You'll need to remove the whitelist entries at: http://searchfox.org/mozilla-central/rev/0079c7adf3b329bff579d3bbe6ac7ba2f6218a19/browser/base/content/test/static/browser_all_files_referenced.js#172
Comment hidden (mozreview-request) |
Assignee | ||
Comment 7•7 years ago
|
||
(In reply to Florian Quèze [:florian] [:flo] from comment #5) > (In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #3) > > https://treeherder.mozilla.org/#/ > > jobs?repo=try&revision=f4266dd448d6749d67476ac21d6a440ffc751e90 > > I'm surprised my browser_all_files_referenced.js test didn't fail on this > try run, maybe your tree didn't have it yet. Thanks, I've cleaned up that up as well now.
Assignee | ||
Comment 8•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=be1c3d5457f340a0902ad6441772a272768f13f5
Pushed by jryans@gmail.com: https://hg.mozilla.org/integration/autoland/rev/6cf1011dbaf3 Remove unreferenced DevTools images. r=pbro
Comment 10•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/6cf1011dbaf3
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•