1348735 - Do not share accesskeys between different labels (web notification permissions)

Status: RESOLVED DUPLICATE of bug 1349841

(Firefox :: Site Identity, defect, P1)

Description

[Francesco Lodolo [:flod]]

Landed in bug 1341742
https://hg.mozilla.org/mozilla-central/rev/a60007195df5

You're sharing the same accesskey (webNotifications.never.accesskey) for two different labels. The fact that it works in English doesn't mean it will work in other languages.

Comment 1

[Johann Hofmann [:johannh]]

Thanks for catching that!

Nihanth, would you like to fix it?

Comment 2

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1348735 - Add a separate accesskey for "Never For This Session" in web notification permission prompts.

Review commit: https://reviewboard.mozilla.org/r/122550/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/122550/

Comment 3

[(inactive) Nihanth Subramanya [:nhnt11]]

Thanks for catching this, good to remember in the future.

Comment 4

[Francesco Lodolo [:flod]]

Comment on attachment 8849793 [details]
Bug 1348735 - Add a separate accesskey for "Never For This Session" in web notification permission prompts.

https://reviewboard.mozilla.org/r/122550/#review124786

::: browser/locales/en-US/chrome/browser/browser.properties:501
(Diff revision 1)
>  webNotifications.notNow=Not Now
>  webNotifications.notNow.accesskey=n
>  webNotifications.never=Never Allow
> -webNotifications.neverForSession=Never For This Session
>  webNotifications.never.accesskey=v
> +webNotifications.neverForSession=Never For This Session

My understanding from the original bug is that this string is available only in Private mode. If that's the case, can we add a localization note?

A simple one would work.

# LOCALIZATION NOTE (webNotifications.neverForSession): this string is displayed
# only in private windows.

Comment 5

[Francesco Lodolo [:flod]]

Comment on attachment 8849793 [details]
Bug 1348735 - Add a separate accesskey for "Never For This Session" in web notification permission prompts.

https://reviewboard.mozilla.org/r/122550/#review124786

> My understanding from the original bug is that this string is available only in Private mode. If that's the case, can we add a localization note?
> 
> A simple one would work.
> 
> # LOCALIZATION NOTE (webNotifications.neverForSession): this string is displayed
> # only in private windows.

Actually, since you use the same letter as accesskey, I assume this would be more precise

# LOCALIZATION NOTE (webNotifications.neverForSession): this string is displayed
# only in private windows, replacing “Never Allow” (they can share the same
# accesskey).

Comment 6

[Johann Hofmann [:johannh]]

Comment on attachment 8849793 [details]
Bug 1348735 - Add a separate accesskey for "Never For This Session" in web notification permission prompts.

https://reviewboard.mozilla.org/r/122550/#review124836

Taking a step back we should just remove the dropdown in private mode as mentioned in bug 1341742 comment 33. When bug 1348257 lands this will be the consistent behavior of all permission prompts in PBM.

Comment 7

[(inactive) Nihanth Subramanya [:nhnt11]]

This bug will no longer be relevant once the string is removed in bug 1349841 (I've set that as blocking this one).

Comment 8

[(inactive) Nihanth Subramanya [:nhnt11]]

Eh, on second thought, I shouldn't resolve this until that one lands. Sorry for the bugspam.

Comment 9

[Francesco Lodolo [:flod]]

I don't think INVALID is the right solution for this bug (it's definitely valid).

We can still consider it a dupe for sake of tracking.