Do not share accesskeys between different labels (web notification permissions)

RESOLVED DUPLICATE of bug 1349841

Status

()

Firefox
Site Identity and Permission Panels
P1
normal
RESOLVED DUPLICATE of bug 1349841
a year ago
a year ago

People

(Reporter: flod, Assigned: nhnt11)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fxprivacy])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

a year ago
Landed in bug 1341742
https://hg.mozilla.org/mozilla-central/rev/a60007195df5

You're sharing the same accesskey (webNotifications.never.accesskey) for two different labels. The fact that it works in English doesn't mean it will work in other languages.
Thanks for catching that!

Nihanth, would you like to fix it?
Flags: needinfo?(nhnt11)
Priority: -- → P1
Whiteboard: [fxprivacy]
Comment hidden (mozreview-request)
(Assignee)

Comment 3

a year ago
Thanks for catching this, good to remember in the future.
Assignee: nobody → nhnt11
Status: NEW → ASSIGNED
Flags: needinfo?(nhnt11)
(Reporter)

Comment 4

a year ago
mozreview-review
Comment on attachment 8849793 [details]
Bug 1348735 - Add a separate accesskey for "Never For This Session" in web notification permission prompts.

https://reviewboard.mozilla.org/r/122550/#review124786

::: browser/locales/en-US/chrome/browser/browser.properties:501
(Diff revision 1)
>  webNotifications.notNow=Not Now
>  webNotifications.notNow.accesskey=n
>  webNotifications.never=Never Allow
> -webNotifications.neverForSession=Never For This Session
>  webNotifications.never.accesskey=v
> +webNotifications.neverForSession=Never For This Session

My understanding from the original bug is that this string is available only in Private mode. If that's the case, can we add a localization note?

A simple one would work.

# LOCALIZATION NOTE (webNotifications.neverForSession): this string is displayed
# only in private windows.
(Reporter)

Comment 5

a year ago
mozreview-review-reply
Comment on attachment 8849793 [details]
Bug 1348735 - Add a separate accesskey for "Never For This Session" in web notification permission prompts.

https://reviewboard.mozilla.org/r/122550/#review124786

> My understanding from the original bug is that this string is available only in Private mode. If that's the case, can we add a localization note?
> 
> A simple one would work.
> 
> # LOCALIZATION NOTE (webNotifications.neverForSession): this string is displayed
> # only in private windows.

Actually, since you use the same letter as accesskey, I assume this would be more precise

# LOCALIZATION NOTE (webNotifications.neverForSession): this string is displayed
# only in private windows, replacing “Never Allow” (they can share the same
# accesskey).

Comment 6

a year ago
mozreview-review
Comment on attachment 8849793 [details]
Bug 1348735 - Add a separate accesskey for "Never For This Session" in web notification permission prompts.

https://reviewboard.mozilla.org/r/122550/#review124836

Taking a step back we should just remove the dropdown in private mode as mentioned in bug 1341742 comment 33. When bug 1348257 lands this will be the consistent behavior of all permission prompts in PBM.
Attachment #8849793 - Flags: review?(jhofmann)
(Assignee)

Comment 7

a year ago
This bug will no longer be relevant once the string is removed in bug 1349841 (I've set that as blocking this one).
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Depends on: 1349841
Resolution: --- → INVALID
(Assignee)

Comment 8

a year ago
Eh, on second thought, I shouldn't resolve this until that one lands. Sorry for the bugspam.
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
(Reporter)

Comment 9

a year ago
I don't think INVALID is the right solution for this bug (it's definitely valid).

We can still consider it a dupe for sake of tracking.
Status: REOPENED → RESOLVED
Last Resolved: a year agoa year ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1349841
You need to log in before you can comment on or make changes to this bug.