1348743 - Sync runs validation/repair on every sync

Status: RESOLVED FIXED

(Firefox :: Sync, defect, P1)

Description

[Mark Hammond [:markh] [:mhammond]]

:( I guess a couple of silver linings are that (a) no one else has noticed and (b) nothing seemed to blow up.

The problem is that the wrong pref for the last validation time is set.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Attachment: Bug 1348743 - avoid running a bookmark validation on every sync.

Review commit: https://reviewboard.mozilla.org/r/121860/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/121860/

Comment 2

[Thom Chiovoloni [:tcsc] (ex-moco)]

Comment on attachment 8849012 [details]
Bug 1348743 - avoid running a bookmark validation on every sync.

https://reviewboard.mozilla.org/r/121860/#review123938

Oof, that looks bad. Probably needs uplift, too.

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8849012 [details]
Bug 1348743 - avoid running a bookmark validation on every sync.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/121860/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a2ec162fa051
avoid running a bookmark validation on every sync. r=tcsc

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I had to back this out for an eslint failure: https://treeherder.mozilla.org/logviewer.html#?job_id=85175794&repo=autoland

https://hg.mozilla.org/integration/autoland/rev/b82302c32cafe3fd8bf3f27f2fff3c4491bfc32b

Comment 6

[Mark Hammond [:markh] [:mhammond]]

(In reply to Wes Kocher (:KWierso) from comment #5)
> I had to back this out for an eslint failure:
> https://treeherder.mozilla.org/logviewer.html#?job_id=85175794&repo=autoland

Sorry about that - I'll re-land a fixed version

Comment 7

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8849012 [details]
Bug 1348743 - avoid running a bookmark validation on every sync.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/121860/diff/2-3/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/01a5e5e8d9bf
avoid running a bookmark validation on every sync. r=tcsc

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/01a5e5e8d9bf

Comment 10

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8849012 [details]
Bug 1348743 - avoid running a bookmark validation on every sync.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1317223 
[User impact if declined]: Sync will do significantly more work than expected.
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: Manually
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Trivial obvious patch in sync
[String changes made/needed]: None

Comment 11

[Gerry Chang [:gchang]]

Comment on attachment 8849012 [details]
Bug 1348743 - avoid running a bookmark validation on every sync.

Fix unnecessary validation on every sync. Aurora54+.

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b103de790ae9