Status
()
People
(Reporter: markh, Assigned: markh)
Tracking
Firefox Tracking Flags
(firefox54 fixed, firefox55 fixed)
Details
MozReview Requests
()
| Submitter | Diff | Changes | Open Issues | Last Updated |
|---|---|---|---|---|
| Loading... | ||||
| Error loading review requests: | ||||
Attachments
(1 attachment)
|
59 bytes,
text/x-review-board-request
|
tcsc
:
review+
gchang
:
approval-mozilla-aurora+
|
Details | Review |
:( I guess a couple of silver linings are that (a) no one else has noticed and (b) nothing seemed to blow up. The problem is that the wrong pref for the last validation time is set.
| Comment hidden (mozreview-request) |
|
||
Comment 2•a year ago
|
||
| mozreview-review | ||
Comment on attachment 8849012 [details] Bug 1348743 - avoid running a bookmark validation on every sync. https://reviewboard.mozilla.org/r/121860/#review123938 Oof, that looks bad. Probably needs uplift, too.
Attachment #8849012 -
Flags: review?(tchiovoloni) → review+
|
|
||
Updated•a year ago
|
||
Priority: -- → P1
| Comment hidden (mozreview-request) |
Pushed by mhammond@skippinet.com.au: https://hg.mozilla.org/integration/autoland/rev/a2ec162fa051 avoid running a bookmark validation on every sync. r=tcsc
|
||
Comment 5•a year ago
|
||
I had to back this out for an eslint failure: https://treeherder.mozilla.org/logviewer.html#?job_id=85175794&repo=autoland https://hg.mozilla.org/integration/autoland/rev/b82302c32cafe3fd8bf3f27f2fff3c4491bfc32b
Flags: needinfo?(markh)
|
(Assignee) | |
Comment 6•a year ago
|
||
(In reply to Wes Kocher (:KWierso) from comment #5) > I had to back this out for an eslint failure: > https://treeherder.mozilla.org/logviewer.html#?job_id=85175794&repo=autoland Sorry about that - I'll re-land a fixed version
Flags: needinfo?(markh)
| Comment hidden (mozreview-request) |
Pushed by mhammond@skippinet.com.au: https://hg.mozilla.org/integration/autoland/rev/01a5e5e8d9bf avoid running a bookmark validation on every sync. r=tcsc
|
||
Comment 9•a year ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/01a5e5e8d9bf
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
|
|
(Assignee) | |
Comment 10•a year ago
|
||
Comment on attachment 8849012 [details] Bug 1348743 - avoid running a bookmark validation on every sync. Approval Request Comment [Feature/Bug causing the regression]: bug 1317223 [User impact if declined]: Sync will do significantly more work than expected. [Is this code covered by automated tests?]: Yes [Has the fix been verified in Nightly?]: Manually [Needs manual test from QE? If yes, steps to reproduce]: No [List of other uplifts needed for the feature/fix]: None [Is the change risky?]: No [Why is the change risky/not risky?]: Trivial obvious patch in sync [String changes made/needed]: None
Attachment #8849012 -
Flags: approval-mozilla-aurora?
|
||
Comment 11•a year ago
|
||
Comment on attachment 8849012 [details] Bug 1348743 - avoid running a bookmark validation on every sync. Fix unnecessary validation on every sync. Aurora54+.
Attachment #8849012 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
|
||
Comment 12•a year ago
|
||
| bugherderuplift | ||
https://hg.mozilla.org/releases/mozilla-aurora/rev/b103de790ae9
status-firefox54: affected → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•