Closed Bug 1348743 Opened 4 years ago Closed 4 years ago

Sync runs validation/repair on every sync

Categories

(Firefox :: Sync, defect, P1)

Product:
Firefox
Component:
Sync
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 55
Tracking Flags:
Tracking Status
firefox54 --- fixed
firefox55 --- fixed

People

(Reporter: markh, Assigned: markh)

References

Details

Attachments

(1 file)

Bug 1348743 - avoid running a bookmark validation on every sync.
59 bytes, text/x-review-board-request
tcsc
: review+
gchang
: approval-mozilla-aurora+
Details 
:( I guess a couple of silver linings are that (a) no one else has noticed and (b) nothing seemed to blow up.

The problem is that the wrong pref for the last validation time is set.
Comment on attachment 8849012 [details]
Bug 1348743 - avoid running a bookmark validation on every sync.

https://reviewboard.mozilla.org/r/121860/#review123938

Oof, that looks bad. Probably needs uplift, too.
Attachment #8849012 - Flags: review?(tchiovoloni) → review+
Priority: -- → P1
Pushed by mhammond@skippinet.com.au:
https://hg.mozilla.org/integration/autoland/rev/a2ec162fa051
avoid running a bookmark validation on every sync. r=tcsc
(In reply to Wes Kocher (:KWierso) from comment #5)
> I had to back this out for an eslint failure:
> https://treeherder.mozilla.org/logviewer.html#?job_id=85175794&repo=autoland

Sorry about that - I'll re-land a fixed version
Flags: needinfo?(markh)
Pushed by mhammond@skippinet.com.au:
https://hg.mozilla.org/integration/autoland/rev/01a5e5e8d9bf
avoid running a bookmark validation on every sync. r=tcsc
https://hg.mozilla.org/mozilla-central/rev/01a5e5e8d9bf
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Comment on attachment 8849012 [details]
Bug 1348743 - avoid running a bookmark validation on every sync.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1317223 
[User impact if declined]: Sync will do significantly more work than expected.
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: Manually
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Trivial obvious patch in sync
[String changes made/needed]: None
Attachment #8849012 - Flags: approval-mozilla-aurora?
Comment on attachment 8849012 [details]
Bug 1348743 - avoid running a bookmark validation on every sync.

Fix unnecessary validation on every sync. Aurora54+.
Attachment #8849012 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.