Closed Bug 1348796 Opened 6 years ago Closed 6 years ago

Windows SM(cgc) opt jobs are using debug builds


(Core :: JavaScript Engine, enhancement)

Not set



Tracking Status
firefox-esr52 --- fixed
firefox53 --- fixed
firefox54 --- fixed
firefox55 --- fixed


(Reporter: jandem, Assigned: sfink)



(2 files)

On Try I got an assertion failure with both opt/debug Windows SM(cgc) jobs, so the opt and debug jobs are probably doing the same thing?
Flags: needinfo?(sphink)
Yes, looks like you're right. I must have lost the ugly --platform handling at some point, which means that all buildbot jobs are going to be getting this wrong. Although I'd prefer buildbot to just die, it looks like I'd better fix this. Thanks.
Assignee: nobody → sphink
Flags: needinfo?(sphink)
arai - I don't know if this would ever be useful to you, but it makes it cleaner to fix the bug here. I'll do that in a separate patch.
Attachment #8849174 - Flags: review?(arai.unmht)
Here is the reason for it. buildbot, and only buildbot, runs --platform win32 compacting

or --platform win32-debug compacting

And it's *much* easier to fix things in than mucking with buildbot.
Attachment #8849175 - Flags: review?(arai.unmht)
Attachment #8849174 - Attachment is obsolete: true
Attachment #8849174 - Flags: review?(arai.unmht)
Comment on attachment 8849174 [details] [diff] [review]
Make debug overridable in

Oops, I think I'm missing part of my bzexport patch stack, which means it's way to obsolete-happy. Reviving this patch; it is *not* obsoleted by the other patch.
Attachment #8849174 - Attachment is obsolete: false
Attachment #8849174 - Flags: review?(arai.unmht)
Comment on attachment 8849174 [details] [diff] [review]
Make debug overridable in

Review of attachment 8849174 [details] [diff] [review]:

::: js/src/devtools/automation/variants/warnaserr
@@ +1,3 @@
>  {
> +    "configure-args": "--enable-warnings-as-errors",
> +    optimize: true

"optimize" (needs quote)
Attachment #8849174 - Flags: review?(arai.unmht) → review+
Comment on attachment 8849175 [details] [diff] [review]
Use buildbot --platform arg to determine --enable-debug vs --disable-debug

Review of attachment 8849175 [details] [diff] [review]:

::: js/src/devtools/automation/
@@ +163,5 @@
> +if opt is None and args.platform:
> +    # Only buildbot passes in --platform. Use it to determine debug vs
> +    # non-debug, since buildbot uses the same variant name for both
> +    # configurations.
> +    opt = ('-debug' in args.platform)

it should be better describing --platform overrides "debug" in variant, in help message.
Attachment #8849175 - Flags: review?(arai.unmht) → review+
Pushed by
Make debug overridable in, r=arai
Use buildbot --platform arg to determine --enable-debug vs --disable-debug, r=arai
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
RyanVM: I would guess this dates all the way back to the -> rewrite, which looks like it landed in Fx50 (bug 1283911).
You need to log in before you can comment on or make changes to this bug.