Change CacheIR spewer to log IC mode

RESOLVED FIXED

Status

()

enhancement
P3
normal
RESOLVED FIXED
2 years ago
Last year

People

(Reporter: jandem, Assigned: evilpie)

Tracking

(Blocks 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qf-])

Attachments

(3 attachments)

Bug 1328140 improves our IC heuristics in a number of ways. We should make sure the spewer still gives us useful information, for instance when we stop trying to attach stubs we should probably still log the fallback hits so we know which ICs are hot.
I am going to work on a few things that would be useful to have now.
Assignee: nobody → evilpies
Status: NEW → ASSIGNED
Attachment #8849526 - Flags: review?(jdemooij)
Posted patch Log IC modeSplinter Review
Attachment #8849527 - Flags: review?(jdemooij)
Comment on attachment 8849526 [details] [diff] [review]
For MegamorphicNativeSlot differentiate between HandleMissing

Review of attachment 8849526 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.
Attachment #8849526 - Flags: review?(jdemooij) → review+
Attachment #8849527 - Flags: review?(jdemooij) → review+
Keywords: leave-open
Pushed by evilpies@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e7a7282cf4f8
For MegamorphicNativeSlot differentiate between HandleMissing. r=jandem
https://hg.mozilla.org/integration/mozilla-inbound/rev/30c3b52e7892
Log CacheIR IC mode. r=jandem
Priority: -- → P3
Attachment #8851280 - Flags: review?(jdemooij)
Comment on attachment 8851280 [details] [diff] [review]
Log address and shape of objects

Review of attachment 8851280 [details] [diff] [review]:
-----------------------------------------------------------------

Nice. Would it be useful to log v.toObject().getClass()->name too?
Attachment #8851280 - Flags: review?(jdemooij) → review+
Thanks for the review. We already log the class-name as type, because we are using InformalValueTypeName for that.
Pushed by evilpies@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bbd6c0e8298e
Log address and shape of objects in CacheIR. r=jandem
Pushed by evilpies@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/99bc59df7d85
probably fix unified build failure. a=bustage
Whiteboard: [qf]
To log fallback hits we would add a else block to all the canAttachStub conditions. However I would like to reuse trackNotAttached and the IRGenerators are only created inside the if block.
Whiteboard: [qf] → [qf-
Whiteboard: [qf- → [qf-]
Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → INACTIVE
Status: RESOLVED → REOPENED
Resolution: INACTIVE → ---
Status: REOPENED → RESOLVED
Closed: Last yearLast year
Resolution: --- → FIXED
Summary: Change CacheIR spewer to log fallback hits and IC mode → Change CacheIR spewer to log IC mode
You need to log in before you can comment on or make changes to this bug.