If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Use dummy tasks to trigger notifications to release-drivers

RESOLVED FIXED

Status

Release Engineering
Release Automation
P2
normal
RESOLVED FIXED
6 months ago
3 months ago

People

(Reporter: rail, Assigned: jlorenzo)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Reporter)

Description

6 months ago
We talked about this with Johan last week. The idea is to:

* add dummy tasks (see https://bugzilla.mozilla.org/show_bug.cgi?id=1318253#c3) that depend on tasks that would run the dummy tasks for the following events:
 ** Beta
 *** en-US available in the candidates directory (with a link to it) - required for QA functional sign off
 *** ready on beta-cdntest - required for QA sign off
 *** ready on beta - required for QA sign off

 ** Release candidates
 *** en-US available in the candidates directory (with a link to it) - required for QA functional sign off
 *** ready on release-localtest - required for QA sign off
 *** ready on beta-cdntest - required for QA sign off
 *** ready on beta - required for QA sign off
 *** ready on release-cdntest - required for QA sign off
 *** ready on release - required for QA sign off

 ** ESR and dot releases
 *** en-US available in the candidates directory (with a link to it) - required for QA functional sign off
 *** ready on release-localtest - required for QA sign off
 *** ready on release-cdntest - required for QA sign off
 *** ready on release - required for QA sign off

* Add notification settings to send emails to release-drivers, something like 

 {{ task_notifications("{} {} updates".format(product, branch), completed=["releasetasks", "release-drivers"], failed=["releasetasks"], exception=["releasetasks"]) | indent(12) }}

* add corresponding config ("release-drivers") to https://github.com/mozilla-releng/pulse-notify/blob/master/pulsenotify/id_configs/prod.yml
(Reporter)

Comment 1

6 months ago
Johan volunteered to look at this next week.
Assignee: nobody → jlorenzo
Priority: -- → P2
Created attachment 8857980 [details] [review]
releasetasks PR
Attachment #8857980 - Flags: review?(rail)
Created attachment 8857981 [details] [review]
pulse-notify PR
Attachment #8857981 - Flags: review?(rail)
(Reporter)

Updated

5 months ago
Attachment #8857980 - Flags: review?(rail) → review+
(Reporter)

Updated

5 months ago
Attachment #8857981 - Flags: review?(rail) → review+
Attachment 8857981 [details] landed on master and production at [1]. Revision deployed on heroku at [2].
Attachment 8857980 [details] landed on master at [3].

Let's see if we get the correct emails on release-automation-notifications.m.c for 54.0b2. If that works, I'll change the line at [4] to send the actual emails to release-drivers.

[1] https://github.com/mozilla-releng/pulse-notify/commit/dabbb973b4822da58f652d05f240172ef1c38eb8
[2] https://dashboard.heroku.com/apps/release-notifications/activity/builds/9d97dfde-e3ba-4080-8311-e234c31e421c
[3] https://github.com/mozilla/releasetasks/commit/71be81d863d11050566a11a6d9af7907e5c2b72c
[4] https://github.com/mozilla/releasetasks/commit/71be81d863d11050566a11a6d9af7907e5c2b72c#diff-f7398c2720fc62d2294273872ed34ec2R50
In the meantime, can we allow emails from release+release-notifications@m.c on release-drivers, Sylvestre? This will automate emails Releng sends to r-d during the release process.
Flags: needinfo?(sledru)
What kind of emails ?
The "*" mentioned in comment #0 ?

Can I haz the content?
Flags: needinfo?(sledru)
Thanks for your super quick answer!

These will be the emails releng has manually sent to tell release-drivers how advanced the release process is. For instance:
* Firefox beta 54.0b2 updates are available on the beta-cdntest channel now <EOM>
* Firefox beta 54.0b2 updates are available on the beta channel now <EOM>

* Firefox release 54.0 updates are available on the release-localtest channel now <EOM>
* Firefox release 54.0 updates are available on the release-cdntest channel now <EOM>
* Firefox release 54.0 updates are available on the release channel now <EOM>

These sentences will be in both subject and content of the emails[1]

[1] https://github.com/mozilla/releasetasks/pull/232/files#diff-f7398c2720fc62d2294273872ed34ec2R47
Flags: needinfo?(sledru)
Super, merci

This is fine. I will accept the first and allow then.
Flags: needinfo?(sledru)
Created attachment 8861791 [details] [review]
releasetasks PR part 2
Attachment #8861791 - Flags: review?(mtabara)
Attachment #8861791 - Flags: review?(mtabara) → review+
Part 2 landed on master at https://github.com/mozilla/releasetasks/commit/b91176d45400124eb196eab86329074e7e0f1e48. I pulled these changes on buildbot-master85 (the release runner machine). Tomorrow, for 54.0b3, emails will be sent to release-drivers. Like said in comment 8, they will need to be accepted in moderation. I'll close this bug once we passed moderation.
See Also: → bug 1361228
Based on the timestamps I see on the latest emails:

> Created at:	Tue, May 16, 2017 at 4:47 AM (Delivered after 3 seconds)

Moderation is not an issue anymore. Otherwise, we would have had a higher delivery time. Closing bug.
Status: NEW → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → FIXED
Depends on: 1372529
Depends on: 1372594
You need to log in before you can comment on or make changes to this bug.