Closed
Bug 1348844
Opened 7 years ago
Closed 7 years ago
Use dummy tasks to trigger notifications to release-drivers
Categories
(Release Engineering :: Release Automation: Other, enhancement, P2)
Release Engineering
Release Automation: Other
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rail, Assigned: jlorenzo)
References
Details
Attachments
(3 files)
We talked about this with Johan last week. The idea is to: * add dummy tasks (see https://bugzilla.mozilla.org/show_bug.cgi?id=1318253#c3) that depend on tasks that would run the dummy tasks for the following events: ** Beta *** en-US available in the candidates directory (with a link to it) - required for QA functional sign off *** ready on beta-cdntest - required for QA sign off *** ready on beta - required for QA sign off ** Release candidates *** en-US available in the candidates directory (with a link to it) - required for QA functional sign off *** ready on release-localtest - required for QA sign off *** ready on beta-cdntest - required for QA sign off *** ready on beta - required for QA sign off *** ready on release-cdntest - required for QA sign off *** ready on release - required for QA sign off ** ESR and dot releases *** en-US available in the candidates directory (with a link to it) - required for QA functional sign off *** ready on release-localtest - required for QA sign off *** ready on release-cdntest - required for QA sign off *** ready on release - required for QA sign off * Add notification settings to send emails to release-drivers, something like {{ task_notifications("{} {} updates".format(product, branch), completed=["releasetasks", "release-drivers"], failed=["releasetasks"], exception=["releasetasks"]) | indent(12) }} * add corresponding config ("release-drivers") to https://github.com/mozilla-releng/pulse-notify/blob/master/pulsenotify/id_configs/prod.yml
Reporter | ||
Comment 1•7 years ago
|
||
Johan volunteered to look at this next week.
Assignee: nobody → jlorenzo
Priority: -- → P2
Assignee | ||
Comment 2•7 years ago
|
||
Attachment #8857980 -
Flags: review?(rail)
Assignee | ||
Comment 3•7 years ago
|
||
Attachment #8857981 -
Flags: review?(rail)
Reporter | ||
Updated•7 years ago
|
Attachment #8857980 -
Flags: review?(rail) → review+
Reporter | ||
Updated•7 years ago
|
Attachment #8857981 -
Flags: review?(rail) → review+
Assignee | ||
Comment 4•7 years ago
|
||
Attachment 8857981 [details] landed on master and production at [1]. Revision deployed on heroku at [2]. Attachment 8857980 [details] landed on master at [3]. Let's see if we get the correct emails on release-automation-notifications.m.c for 54.0b2. If that works, I'll change the line at [4] to send the actual emails to release-drivers. [1] https://github.com/mozilla-releng/pulse-notify/commit/dabbb973b4822da58f652d05f240172ef1c38eb8 [2] https://dashboard.heroku.com/apps/release-notifications/activity/builds/9d97dfde-e3ba-4080-8311-e234c31e421c [3] https://github.com/mozilla/releasetasks/commit/71be81d863d11050566a11a6d9af7907e5c2b72c [4] https://github.com/mozilla/releasetasks/commit/71be81d863d11050566a11a6d9af7907e5c2b72c#diff-f7398c2720fc62d2294273872ed34ec2R50
Assignee | ||
Comment 5•7 years ago
|
||
In the meantime, can we allow emails from release+release-notifications@m.c on release-drivers, Sylvestre? This will automate emails Releng sends to r-d during the release process.
Flags: needinfo?(sledru)
Comment 6•7 years ago
|
||
What kind of emails ? The "*" mentioned in comment #0 ? Can I haz the content?
Flags: needinfo?(sledru)
Assignee | ||
Comment 7•7 years ago
|
||
Thanks for your super quick answer! These will be the emails releng has manually sent to tell release-drivers how advanced the release process is. For instance: * Firefox beta 54.0b2 updates are available on the beta-cdntest channel now <EOM> * Firefox beta 54.0b2 updates are available on the beta channel now <EOM> * Firefox release 54.0 updates are available on the release-localtest channel now <EOM> * Firefox release 54.0 updates are available on the release-cdntest channel now <EOM> * Firefox release 54.0 updates are available on the release channel now <EOM> These sentences will be in both subject and content of the emails[1] [1] https://github.com/mozilla/releasetasks/pull/232/files#diff-f7398c2720fc62d2294273872ed34ec2R47
Flags: needinfo?(sledru)
Comment 8•7 years ago
|
||
Super, merci This is fine. I will accept the first and allow then.
Flags: needinfo?(sledru)
Assignee | ||
Comment 9•7 years ago
|
||
Attachment #8861791 -
Flags: review?(mtabara)
Updated•7 years ago
|
Attachment #8861791 -
Flags: review?(mtabara) → review+
Assignee | ||
Comment 10•7 years ago
|
||
Part 2 landed on master at https://github.com/mozilla/releasetasks/commit/b91176d45400124eb196eab86329074e7e0f1e48. I pulled these changes on buildbot-master85 (the release runner machine). Tomorrow, for 54.0b3, emails will be sent to release-drivers. Like said in comment 8, they will need to be accepted in moderation. I'll close this bug once we passed moderation.
Assignee | ||
Comment 11•7 years ago
|
||
Based on the timestamps I see on the latest emails:
> Created at: Tue, May 16, 2017 at 4:47 AM (Delivered after 3 seconds)
Moderation is not an issue anymore. Otherwise, we would have had a higher delivery time. Closing bug.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•