Create Initial Conduit Demo

RESOLVED FIXED

Status

Conduit
General
RESOLVED FIXED
7 months ago
7 months ago

People

(Reporter: davidwalsh, Assigned: davidwalsh)

Tracking

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

7 months ago
* create pipeline demo project in conduit, conduitdemo
* create docker-compose.yml, call other project dirs
* get hg extension code from vct into new docker container


Acceptance:

* docker-compose run hg push http://[stagingserver]/[createcommitcommand]
* commitindex service prints out log message stating it received POST
(Assignee)

Updated

7 months ago
Assignee: nobody → dwalsh
Comment hidden (mozreview-request)
(Assignee)

Comment 2

7 months ago
mozreview-review
Comment on attachment 8849170 [details]
Conduit:  Create the initial conduit demo (Bug 1348880).

https://reviewboard.mozilla.org/r/122008/#review124004

Instructions for testing:


Terminal 1:
$ docker-compose run demo /bin/sh

Terminal 2:
$ hg clone http://hgserver:8080/testrepo
$ cd testrepo

$ hg help # See "conduit" and "reviewboard" listed under extensions
$ curl http://hgserver:8080/testrepo/commitindex # See JSON to prove our extension works

$ touch blah.js
$ hg add blah.js
$ hg commit -m "This is a test commit"
$ hg push

$ hg conduit --rev . http://hgserver:8080/testrepo # View 400 error in both terminals

Flip to Terminal 1, view POST

Comment 3

7 months ago
mozreview-review
Comment on attachment 8849170 [details]
Conduit:  Create the initial conduit demo (Bug 1348880).

https://reviewboard.mozilla.org/r/122008/#review124030

::: conduitdemo/docker-compose.yml:20
(Diff revision 1)
> +    ports:
> +      - "8080:8080"

I don't think we need to expose ports here.  Developers can create a docker-compose.override.yml file to expose whatever ports they want for ease of development.

::: conduitdemo/docker-compose.yml:55
(Diff revision 1)
> +    ports:
> +      - "8888:80"

I don't think we need to expose ports here.  Developers can create a docker-compose.override.yml file to expose whatever ports they want for ease of development.

::: conduitdemo/docker-vct-hg/Dockerfile:1
(Diff revision 1)
> +FROM alpine

We should pin alpine to major.minor to avoid problems like we encountered with nodejs in the autoland service.

::: conduitdemo/docker-vct-hg/Dockerfile:1
(Diff revision 1)
> +FROM alpine

Needs a MPL copyright license stanza
Attachment #8849170 - Flags: review?(mars) → review-
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 6

7 months ago
mozreview-review
Comment on attachment 8849170 [details]
Conduit:  Create the initial conduit demo (Bug 1348880).

https://reviewboard.mozilla.org/r/122008/#review124066
Attachment #8849170 - Flags: review?(mars) → review+

Comment 7

7 months ago
Pushed by mfogels@mozilla.com:
https://hg.mozilla.org/automation/conduit/rev/c462aef96eb2
Conduit:  Create the initial conduit demo . r=mars
Status: NEW → RESOLVED
Last Resolved: 7 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.