1348938 - Add "be" back to Fennec all-locales for single-locale builds

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, enhancement)

Description

[Delphine Lebédel [:delphine - Use needinfo]]

Please add the Belarussian (be) locale back to all-locales to start fennec single-locale builds in aurora, and add Fennec to be team's dashboard.

Comment 1

[Delphine Lebédel [:delphine - Use needinfo]]

Attachment: bug1348938.patch

Sorry this took a while to get to!

Comment 2

[Francesco Lodolo [:flod]]

Comment on attachment 8873248 [details] [diff] [review]
bug1348938.patch

Can you try using mozreview to create this patch? It's the same process you use for search, just on a different file.

Comment 3

[Owais Kazi]

Attachment: patch

Is this change correct? If yes I'll upload a patch with mozreview soon

Comment 4

[Francesco Lodolo [:flod]]

(In reply to Owais Kazi from comment #3)
> Created attachment 8873356 [details]
> patch
> 
> Is this change correct? If yes I'll upload a patch with mozreview soon

This is not a patch, it's the entire file. 

Having said that, thank you for the offer but this is something I prefer to fix within our team for sanity (PM of localization doing the patch, peer doing review).

Comment 5

[Owais Kazi]

Yeah I just showed up the file. If changes were approved, I would have uploaded a patch. But anyways Thanks :)

Comment 6

[Delphine Lebédel [:delphine - Use needinfo]]

Attachment: Bug 1348938 - (be) Add Belarusian locale back to Fennec single-locale builds

Review commit: https://reviewboard.mozilla.org/r/144936/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/144936/

Comment 7

[Francesco Lodolo [:flod]]

Comment on attachment 8873553 [details]
Bug 1348938 - (be) Add Belarusian locale back to Fennec single-locale builds

https://reviewboard.mozilla.org/r/144936/#review148916

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/caad4bc199aa
(be) Add Belarusian locale back to Fennec single-locale builds r=flod

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/caad4bc199aa

Comment 10

[Axel Hecht [:Pike]]

Delphine, we'll want an updated sign-off for Belarus Fennec. There's currently one lingering from back in the 51 days.

Comment 11

[Francesco Lodolo [:flod]]

(In reply to Axel Hecht [:Pike] from comment #10)
> Delphine, we'll want an updated sign-off for Belarus Fennec. There's
> currently one lingering from back in the 51 days.

This bug is about single locale builds, I don't think we need a sign-off for that?

Comment 12

[Axel Hecht [:Pike]]

I don't know the status of single locale builds on beta :-?

Comment 13

[Delphine Lebédel [:delphine - Use needinfo]]

Didn't see the last 2 comments so I did the sign-off regardless.
I always forget we have (had? no idea) beta single locale builds... I've searched all over our ftp and couldn't find it. I found one link from a couple years ago but it's broken.

Comment 14

[Francesco Lodolo [:flod]]

It depends on version, but you can see we have Lao (lo)
http://archive.mozilla.org/pub/mobile/releases/54.0b8/android-api-15/lo/

Comment 15

[Sorina Florean [:sflorean]]

Verified as fixed in build 55.0a1 from (2017-06-11).
Device: Nexus 6 (Android 7.0).