134897 - Mail account info and message display not working for new profile created in Quick Launch mode

Status: VERIFIED FIXED

(Core Graveyard :: QuickLaunch (AKA turbo mode), defect)

Description

[esther]

Using build 20020401 on winxp, a New Profile does not display the newly added
mail account info correctly in folder pane or Account settings and does not
display mail messages in message pane.  (Note this was reported in bug 99117 in
Nov 2001, but that bug had several different scenarios resulting in it being
fixed and resolved  for the Folders missing only.  Therefore this bug is being
opened for this specific scenario, please do not add additional scenarios to
this bug).  

Setup:
I was not in Quick launch mode when I started.
I installed a new version of the app in a new directory (this may not be a
necessary part of the scenario but I want to add it in case this is hard to
reproduce).
1. Launch app with existing Profile.
2. Check the box in the Advanced preferences to turn on Quick Launch
3. Exit the app and OK the Quick Launch notification.
4. Launch the app in Profile Manager
5. Add a new profile, add a new mail account (note the account I added is a POP
account which happens to be one of the accounts I have in the existing Profile
that I was using previous to creating this profile, this may be important)

Result: The Folder pane only showed Local Folders not the account I just added.

6. Exit the app and launch again, select the same profile, go to mail and select
a message.

Result: The Folder pane shows an account with folders but the name of the
account is missing and the selected message is not displaying (see 1st attached
image).  
The account should be qatest04.

7. Go to Account settings to see what it displays
Result: No account is listed (see 2nd image)

8. Turn off Quick Launch, relaunch app, open same profile, go to mail
Result:  Folder pane correctly shows POP mail account, selected message correcly
displays message.  (see 3rd attached image)

9. Open Account setting to display setings.
Result: Correct  account information is displayed. (see 4th attached image).

Comment 1

[esther]

Attachment: account info and message not displaying

image showing folder pane account info and message pane not displaying
correctly while in Quick Launch mode

Comment 2

[esther]

Attachment: Accounts settings not showing info

image shows account settings not displaying correctly while in Quick Launch
mode

Comment 3

[esther]

Attachment: account info and message pane displayed correctly with Quick Launch off

image shows how account info and message pane displays correctly after turning
off Quick Launch

Comment 4

[esther]

Attachment: account settings diplayed correctly with Quick Launch off

image shows account settings displaying correctly when Quick Launch is turned
off.

Comment 5

[Gayatri Rimola]

Nominating...

Comment 6

[Samir Gehani]

Nav triage team: nsbeta1+/adt2

Esther,
Do the missing UI symptoms recur if you ``truely'' shutdown Netscape from the
``Exit'' menu item of the Netscape system tray icon/by restarting the computer?
 Or does this problem only occur the first time when you are setting up the
account and goes away on a reboot?  Thanks.

Comment 7

[esther]

Note, in original scenario after step 2, launch mail and log into my 1st mail
account (it's not the same one I'll be adding in step 5).

Comment 8

[esther]

Samir to answer your question, I exit and relaunch the app several times aafter
step 7 just to check to see if the UI would improve, this was done with the
system still up and running.  The UI doesn't clear up.  I haven't tried shutting
the system shutdown, but I expect it too would fix the UI. Cavin was just in my
cube and saw the problem following my steps, he thinks he has a fix and is
trying it now on his debug build.  I will try the system shut down too. 

Comment 9

[Cavin Song]

It does seem to work fine with my local NS debug build with fix of bug 134274. 
With the same profiles I used to test this problem, commercial build crashed on 
me so I can't say it's definitely fixed or not. Just cheked in fix of bug 134274 
so we can try Monday's build to see if the problem still exists. Later I'll also 
try the local build without the fix of bug 134274 and see if the behavior 
changes. If it does change then I'll post another comment.

Comment 10

[esther]

Samir, if I shut down the system and launch NS6, the profile behaves correctly,
the UI displays correctly.  Note, when I then exit the app, I get the Quick
Launch notification so I'm not really in Quick Launch after rebooting am I?  I
think that would be the same as step 8, turning Quick Launch Off.  

Comment 11

[Cavin Song]

Ref: Comment #9.

OK, I was able to see the exact problem (ie, folder pane only showed Local 
Folders) without the fix of bug 134274. So it looks like this particular problem 
will be fixed.

But I'm also seeing other problems which I'm still not quite sure about. I need 
to play with it more before coming to a conclusion.

Comment 12

[Cavin Song]

The problem I saw is that I could log into the pop server (yes, I was promted 
for password which is correct) after creating the new profile but I could not 
read any of the msgs in INBOX. I got the following assertion in this case:

  Couldn't get message header.
  nsMailboxProtocol.cpp, line 469

Remember, I was running the debug build with the fix of bug 134274. My guess is 
that the physical file for this INBOX still points to the INBOX file associated 
with the 1st/previous profile. I'll investigate this.

Comment 13

[Cavin Song]

The problem was caused by not resetting:

1. A control var which initializes local folder objects.
2. The folder pathnames in the folder object associated with the folders from 
the account in the first/previous profile. In other words, we are not creating 
new folders for the new account, rather, we use those from the first profile. 

IMAP and News have the exact same problem. I'll attach a patch to the problem 
next.

Comment 14

[Cavin Song]

Taking from Bill.

Comment 15

[Cavin Song]

Attachment: Proposed patch, v1

Reset control var 'mInitialized' (or 'm_initialized' for imap) so that the
folder obj will be re-initialized for new profiles. Also reset 'mPath' and
'm_pathName' for imap so that it points to the right physical location for the
new profile (instead of carrying over from the previous profile).

Comment 16

[Cavin Song]

Ccing David for review.

Comment 17

[David :Bienvenu]

Comment on attachment 78487 [details] [diff] [review]
Proposed patch, v1

+  if (m_pathName)
+  {
+    delete m_pathName;
+    m_pathName = nsnull; 
+  }
you don't need to check m_pathName - delete null is not an error. Other than
that, r=bienvenu

Comment 18

[(not reading, please use [e-mail] instead)]

Comment on attachment 78487 [details] [diff] [review]
Proposed patch, v1

sr=sspitzer, once you address bienvenu's issue.

Comment 19

[Asa Dotzler [:asa]]

Comment on attachment 78487 [details] [diff] [review]
Proposed patch, v1

a=asa (on behalf of drivers) for checkin to the 1.0 branch

Comment 20

[scottputterman]

Cavin, while waiting for ADT approval, can you get this checked into the trunk?

Comment 21

[scottputterman]

Seth, can you check this into the trunk for Cavin?

Comment 22

[(not reading, please use [e-mail] instead)]

yes, I'll land this for cavin.

Comment 23

[(not reading, please use [e-mail] instead)]

fix landed on the trunk.

Comment 24

[Michael Buckland]

Please test and update the bug.

Comment 25

[Grace Bush]

sorry about that- tested yesterday on XP - guess my comments didn't stick.
tested on trunk 2002041603- using steps listed by reporter.  This is fixed.
One thing I noted was that on the POP account (profile 2) - I had to click 
on 'get messages' to see the messages (whether in QuickLaunch or not)- not sure 
if this is correct behavior since I rarely use POP mail.

After creating a new second profile with same POP account as profile 1, I did 
see the folders for the account as well as local folders.  The account was 
listed in Account settings.  Messages are displayed after clicking on 'get 
messages'.

Comment 26

[esther]

This bug as stated is fixed, however because it's fixed it uncovered another bug
with a new scenario for profile confusion regarding mail accounts when switching
between profiles.  
Fixed are: 
1.) The missing Inbox is not missing anymore.
2.) Unable to read messages after loggin in, is not a bug anymore
The new bug:
1.) When switching between Profiles, where the same mail account is added to
each of these Profiles, newly created folders show up in both Profiles, they
should only show up in the Profile from which it was created. 

Comment 27

[scottputterman]

adding adt1.0.0+. Please check into the branch as soon as possible and add the
fixed1.0.0 keyword.

If you haven't already, please create a new bug for what's written in the
comment above this.  We should look into that. But that seems less important
than this bug since most users won't create 2 profiles with the same account.

Comment 28

[scottputterman]

marking fixed since this was fixed on the trunk

Comment 29

[scottputterman]

really marking fixed this time.

Comment 30

[esther]

I created a new bug for the new findings and nominated it.  Read that bug for my
reasons for nominating it.  Bug 138217.

Comment 31

[esther]

verified on trunk

Comment 32

[Cavin Song]

Fixed on 1.0.0 branch.

Comment 33

[Grace Bush]

changed pref to test branch build for win 20020603 (allow multiple profiles)
verified on the branch