nsImageLoadingContent::MakePendingRequestCurrent needs to transfer mPendingRequestRegistered

RESOLVED FIXED in Firefox 55

Status

()

Core
DOM: Core & HTML
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: tnikkel, Assigned: tnikkel)

Tracking

Trunk
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
From bug 1346501, comment 16.

(In reply to Mats Palmgren (:mats) from comment #16)
> BTW, I was looking through the nsImageLoadingContent code and found a
> potential issue
> in nsImageLoadingContent::MakePendingRequestCurrent:
> http://searchfox.org/mozilla-central/rev/
> 557f236c19730116d3bf53c0deef36362cafafcd/dom/base/nsImageLoadingContent.
> cpp#1309
> Shouldn't mPendingRequestRegistered be copied to mCurrentRequestRegistered
> there
> and then reset?
(Assignee)

Comment 1

a year ago
Created attachment 8849274 [details] [diff] [review]
patch
Attachment #8849274 - Flags: review?(mats)
Comment on attachment 8849274 [details] [diff] [review]
patch

LGTM ;-)
Attachment #8849274 - Flags: review?(mats) → review+

Comment 3

a year ago
Pushed by tnikkel@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a058d871d52f
nsImageLoadingContent::MakePendingRequestCurrent should transfer mPendingRequestRegistered flag to mCurrentRequestRegistered. r=mats
https://hg.mozilla.org/mozilla-central/rev/a058d871d52f
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.