Closed Bug 1349009 Opened 3 years ago Closed 3 years ago

[ESLint] Clean up responsivedesign.jsm

Categories

(DevTools :: Responsive Design Mode, defect, P3)

defect

Tracking

(firefox55 fixed)

RESOLVED FIXED
Firefox 55
Tracking Status
firefox55 --- fixed

People

(Reporter: jryans, Assigned: jryans)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
This ended up finding the `flags` module that was never required here...  This might fix some intermittent tests, since we weren't setting testing mode correctly.
Comment on attachment 8849329 [details]
Bug 1349009 - Fix ESLint errors in responsivedesign.jsm.

https://reviewboard.mozilla.org/r/122126/#review124474

Thank you.  This looks good to me.

::: devtools/client/responsivedesign/responsivedesign.jsm:249
(Diff revision 2)
>      try {
>        if (Services.prefs.getBoolPref("devtools.responsiveUI.rotate")) {
>          this.rotate();
> +      }
> +    } catch (e) {
> +      // Ignored

If it can fail, should we log the failure?
Attachment #8849329 - Flags: review?(ttromey) → review+
(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #4)
> This ended up finding the `flags` module that was never required here... 
> This might fix some intermittent tests, since we weren't setting testing
> mode correctly.

Oops, looks like `flags` was actually there before, I must have removed it by accident while editing... x_x Anyway, at least the linting told me about it...!
Comment on attachment 8849329 [details]
Bug 1349009 - Fix ESLint errors in responsivedesign.jsm.

https://reviewboard.mozilla.org/r/122126/#review124474

> If it can fail, should we log the failure?

It can fail since there's no default value for it, so failure is actually the default path...  Since this code is hopefully removed soon anyway, I'll clarify the comment (rather than adding a default value).
Pushed by jryans@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/ef9b3cb0421e
Fix ESLint errors in responsivedesign.jsm. r=tromey
https://hg.mozilla.org/mozilla-central/rev/ef9b3cb0421e
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.