Closed
Bug 1349056
Opened 7 years ago
Closed 7 years ago
Fix wrong mask layer transform in CompositorD3D11
Categories
(Core :: Graphics: Layers, enhancement)
Core
Graphics: Layers
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: dvander, Assigned: dvander)
Details
Attachments
(1 file)
|
5.53 KB,
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
layout/reftests/layers/mask-layer-transform.html looks really whacky on Windows (like a misshapen blob). It looks correct on other compositors and browsers. The reftest passes anyway.
|
Assignee | |
Comment 1•7 years ago
|
||
200KB of bytecode changes not included in the diff.
Attachment #8849355 -
Flags: review?(mstange)
|
|
Assignee | |
Comment 2•7 years ago
|
||
This makes CompositorD3D11 match CompositorOGL's behavior.
|
||
Comment 3•7 years ago
|
||
Comment on attachment 8849355 [details] [diff] [review] fix Review of attachment 8849355 [details] [diff] [review]: ----------------------------------------------------------------- I reviewed this by comparing it to the CompositorOGL implementation and it looks like it matches.
Attachment #8849355 -
Flags: review?(mstange) → review+
Pushed by danderson@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/0aa8279b8266 Fix mask layer transforms in the D3D11 compositor. (bug 1349056, r=mstange)
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0aa8279b8266
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•