Closed Bug 1349082 Opened 3 years ago Closed 2 years ago

don't use legacy .Count() on nsIArray in c-c

Categories

(MailNews Core :: Filters, enhancement, trivial)

enhancement
Not set
trivial

Tracking

(thunderbird61 fixed, seamonkey2.58 fixed)

RESOLVED FIXED
Thunderbird 61.0
Tracking Status
thunderbird61 --- fixed
seamonkey2.58 --- fixed

People

(Reporter: aceman, Assigned: aceman)

References

()

Details

Attachments

(1 file, 1 obsolete file)

1.62 KB, patch
jorgk-bmo
: review+
frg
: review+
Details | Diff | Splinter Review
.Count() on nsIArray is defined in https://dxr.mozilla.org/comm-central/source/mozilla/xpcom/ds/nsIArrayExtensions.idl as some temporary compatibility for callers assuming/migrating from nsISupportsArray. Now that nsISupportsArray is gone, these extensions may be also endangered (unneeded).

So convert the few uses before the support goes away and we do not notice it in JS.
Attached patch patch (obsolete) — Splinter Review
Attachment #8849365 - Flags: review?(philip.chee)
Attached patch patch v1.1Splinter Review
Unbitrotted.
Attachment #8849365 - Attachment is obsolete: true
Attachment #8849365 - Flags: review?(philip.chee)
Attachment #8973483 - Flags: review?(jorgk)
Attachment #8973483 - Flags: review?(frgrahl)
Comment on attachment 8973483 [details] [diff] [review]
patch v1.1

What a difficult review ;-)
Attachment #8973483 - Flags: review?(jorgk) → review+
Comment on attachment 8973483 [details] [diff] [review]
patch v1.1

> What a difficult review ;-)

+1 and thanks
Attachment #8973483 - Flags: review?(frgrahl) → review+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/44d358d734d2
don't use legacy .Count() on nsIArray. r=jorgk,frg
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 61.0
You need to log in before you can comment on or make changes to this bug.