Closed Bug 1349096 Opened 3 years ago Closed 3 years ago

Downloads panel moves up and down with the downloads icon

Categories

(Firefox :: Downloads Panel, defect)

54 Branch
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 55
Tracking Status
firefox52 --- unaffected
firefox-esr52 --- unaffected
firefox53 --- unaffected
firefox54 --- verified
firefox55 --- verified

People

(Reporter: 684sigma, Assigned: rexboy)

References

Details

(Keywords: regression, ux-minimalism)

Attachments

(1 file)

I noticed a problem in Firefox Nightly 55. It doesn't happen in ESR 45, Beta 53.
Sometimes downloads panel moves up and down a bit when I open it.
It happens unpredictably, however, I noticed one specific scenario when it happens

1. Open https://www.ssyoutube.com/watch?v=Sqz5dbs5zmo
2. drag and drop link "Download" on the page to downloads button
3. Click on the downloads button

Result: Downloads panel moves up and down with the downloads icon
Expected: Downloads panel should stay still (or the animation itself should only happen for the very first time)

Regardless from described bug, I'd appreciate any advice on removing that animation, because it seems distracting.
Add a pref to control?
Blocks: 1270012
Has STR: --- → yes
Keywords: ux-minimalism
Version: 55 Branch → 54 Branch
Hm, this bug isn't a request of any pref, in this bug I only assumed that even if downloads icon is animated, the panel shouldn't move. (If the panel should move up/down by design, then ofc this bug is invalid).

I managed to remove all mentioned animations by adding this code in userChrome.css

#downloads-indicator-anchor{
  animation: none!important;
  transition:none!important;
}
This bug is especially bad in conjunction with Bug 1349094, watch attachment 8849657 [details].
Keywords: regression
See Also: → 1349094
Mozregression-gui generated this regression range:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=cce63d5f6ddeb27dd7a2e0bb98b2fc34d4d3f606&tochange=eefb0717c7cbb7e53db33106433e09ab55d267ce
->
1270012 – Visual for download animation on download start whenever a download is started
https://bugzilla.mozilla.org/show_bug.cgi?id=1270012

KM Lee, please confirm that this is intentional behavior, or confirm the bug.
Also, this bug + Bug 1349094 are causing very distracting flickering.
Flags: needinfo?(rexboy)
The animation moved the anchor and therefore the panel too.
Seems we need to change either target of the animation or the anchor.
Assignee: nobody → rexboy
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(rexboy)
Got a simple fix. I targeted animation to its children icon instead.
Tested on different OSes and the panel didn't move with the animation.

Paolo would you take a look on this trivial patch?
Thanks!
Comment on attachment 8856404 [details]
Bug 1349096 - Prevent download panel from moving up and down with download start animation.

https://reviewboard.mozilla.org/r/128342/#review131372

Please use the child selector ">" for better performance. There is only one element in-between, so it shouldn't impact readability. r+ with this change.
Attachment #8856404 - Flags: review?(paolo.mozmail) → review+
OK, I've updated the patch and tested. Thank you Paolo!

tagging checkin-needed.
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/819f8b4c80b6
Prevent download panel from moving up and down with download start animation. r=Paolo
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/819f8b4c80b6
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Please request Aurora approval on this when you get a chance.
Comment on attachment 8856404 [details]
Bug 1349096 - Prevent download panel from moving up and down with download start animation.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1270012
[User impact if declined]: Confusing UI behavior on download panel
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: No
[Needs manual test from QE? If yes, steps to reproduce]: See STR on bug description
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Trivial CSS change involving only Download Button
[String changes made/needed]: None
Flags: needinfo?(rexboy)
Attachment #8856404 - Flags: approval-mozilla-aurora?
Flags: qe-verify+
Comment on attachment 8856404 [details]
Bug 1349096 - Prevent download panel from moving up and down with download start animation.

Fix an UI regression. Aurora54+.
Attachment #8856404 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
I have reproduced this bug with Nightly 55.0a1 (2017-03-20) (64-bit) on Ubuntu 16.04 LTS!

This bug's fix is verified with latest Nightly and Developer Edition (Aurora)! 


Build ID   : 20170419100228
User Agent : Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0

Build ID   : 20170419074707
User Agent : Mozilla/5.0 (X11; Linux x86_64; rv:54.0) Gecko/20100101 Firefox/54.0

[bugday-20170419]
This bug has reproduced on windows7 32bit 

Fixing bug is verified on latest Developer Edition-- Build ID:( 20170423004011 ),User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:54.0) Gecko/20100101 Firefox/54.0

[bugday-20170419]
I reproduced this issue using Fx 55.0a1, build ID: 20170320030209, on Windows 10 x64.
I can confirm this issue is fixed, I verified using Fx 55.0a1, build ID: 20170423030206 and Fx 54.0a2, build ID: 20170418004027, on Windows 10 x64, mac OS X 10.12.3 and Ubuntu 14.04 LTS.

Cheers!
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.