1349120 - Win64 Opt TEST-UNEXPECTED-FAIL | toolkit/mozapps/update/tests/unit_service_updater/checkUpdaterSigSvc.js | xpcshell return code: 0 (TC only and will be fixed when TC supports signing, etc.)

Status: RESOLVED DUPLICATE of bug 1352185

(Toolkit :: Application Update, defect, P5)

Description

[Ting-Yu Chou [:ting] (away)]

Normal win64 build is also failed on taskcluster for this one.

08:32:47     INFO -  TEST-START | toolkit/mozapps/update/tests/unit_service_updater/checkUpdaterSigSvc.js
08:32:48  WARNING -  TEST-UNEXPECTED-FAIL | toolkit/mozapps/update/tests/unit_service_updater/checkUpdaterSigSvc.js | xpcshell return code: 0
08:32:48     INFO -  TEST-INFO took 1078ms
08:32:48     INFO -  >>>>>>>
08:32:48     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
08:32:48     INFO -  "08:32:48:268 | TEST-INFO | Z:/task_1489392969/build/tests/xpcshell/tests/toolkit/mozapps/update/tests/unit_service_updater/checkUpdaterSigSvc.js | [run_test : 22] Launching maintenance service bin: Z:\\task_1489392969\\build\\application\\firefox\\maintenanceservice.exe to check updater: Z:\\task_1489392969\\build\\application\\firefox\\updater.exe signature."
08:32:48  WARNING -  TEST-UNEXPECTED-FAIL | toolkit/mozapps/update/tests/unit_service_updater/checkUpdaterSigSvc.js | run_test - [run_test : 37] the maintenance service exit value should be 0 - 1 == 0
08:32:48     INFO -  Z:/task_1489392969/build/tests/xpcshell/tests/toolkit/mozapps/update/tests/unit_service_updater/checkUpdaterSigSvc.js:run_test:37
08:32:48     INFO -  Z:\task_1489392969\build\tests\xpcshell\head.js:_execute_test:536
08:32:48     INFO -  -e:null:1
08:32:48     INFO -  exiting test
08:32:48     INFO -  <<<<<<<

Comment 1

[Robert Strong (they/them - no direct email)]

Can you provide a link to the log file? I'd like to check the tests that follow since this test is mainly to verify that the binary is signed as well as other requirements of the build process. Thanks

Comment 2

[Ting-Yu Chou [:ting] (away)]

Attachment: live_backing.log

The log is from win64 asan on taskcluster.:

  https://treeherder.mozilla.org/#/jobs?repo=try&revision=0c3647fea293f7a04360316fdbc98b4a820f909c&filter-tier=1&filter-tier=2&filter-tier=3&selectedJob=83333921

I have another run for normal win64:

  https://treeherder.mozilla.org/#/jobs?repo=try&revision=c79d609647bcc939405fe8e19753020c52182513&filter-tier=1&filter-tier=2&filter-tier=3&selectedJob=81387029

but the log isn't there anymore.

I expect this is something about test environment, e.g., maintenanceservice is installed or not.

Comment 3

[Ting-Yu Chou [:ting] (away)]

Seems this is related to bug 1323732.

Comment 4

[Robert Strong (they/them - no direct email)]

I can tell that the failing TC system isn't even running the maintenance service tests so it isn't setup the same as the non TC systems. This appears to be a build system issue.

Comment 5

[Robert Strong (they/them - no direct email)]

Attachment: patch

Comment 6

[Robert Strong (they/them - no direct email)]

Could you try out the patch on try to see if it fixes this for you? Thanks!

Comment 7

[Ting-Yu Chou [:ting] (away)]

I am not sure is skipping the test that something releng prefer for TaskCluster, :grenade?

Comment 8

[Robert Strong (they/them - no direct email)]

Note: this is at the very least due to binary signing (possibly other TC issues as well) and all of the rest of the maintenance service tests already don't run on TC because TC builds don't support everything the non TC builds support. Also see bug 1322705

Comment 9

[Rob Thijssen [:grenade (EET/UTC+0300)]]

we have some tests disabled because they are not validated as normally green on both Win 7 and 10. if the failing test is one of those commented out in https://dxr.mozilla.org/mozilla-central/source/taskcluster/ci/test/test-sets.yml#127, i wouldn't worry too much. we'll get to enabling those as we fix all the env problems.

i saw in comment 4 that the missing maintenance service is causing problems, so i have just added that to both win 7 and 10 test workers (https://github.com/mozilla-releng/OpenCloudConfig/commit/9578e3cc98a06195c0043f974d00bf54fec660de). those amis should propagate in the next few hours and i would hope that errors relating to that service being missing, should start to disappear from test logs going forward.

errors relating to unsigned binaries will continue for a while as the effort to make signing work for tc win builds is ongoing. you can follow progress on that in bug 1277591.

Comment 10

[Ting-Yu Chou [:ting] (away)]

Something seemed changed, now there's not only checkUpdaterSigSvc.js failed, but also the other tests under unit_service_updater:

  https://treeherder.mozilla.org/#/jobs?repo=try&revision=e02c27228db675ea25c93f84cf4cc4cd94e63414&filter-tier=1&filter-tier=2&filter-tier=3&group_state=expanded&selectedJob=85859637

Not sure what's changed, but with attachment 8849647 [details] [diff] [review], checkUpdaterSigSvc.js still runs and fails.

Comment 11

[Robert Strong (they/them - no direct email)]

Since this only affect TC on Windows which isn't completely implemented per the related bugs and there is a significant backload of other app update work I'm going to let the TC bugs be responsible for fixing this.