1349160 - Dismissing Print dialogue crashes Firefox

Status: RESOLVED FIXED

(Firefox :: Untriaged, defect)

Description

[Jan Tojnar]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0
Build ID: 20170320110254

Steps to reproduce:

1. Open Print dialog. (Using both menu and keyboard short cut works.)
2. Dismiss it. (Using “Cancel” button, pressing Escape key or closing the window all work.)

I have tried fresh profile.


Actual results:

Nightly crashes

Comment 1

[Pascal Chevrel:pascalc]

I can't reproduce on Ubuntu 16.04 with:
Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0 ID:20170320110254 CSet: 1b9293be51637f841275541d8991314ca56561a5

Can you provide a crash ID? (about:crashes)

Comment 2

[Jan Tojnar]

I am on Manjaro with Openbox.

> Can you provide a crash ID? (about:crashes)

https://crash-stats.mozilla.com/report/index/0ec0ca19-4709-47f1-a078-f4fad2170321

Comment 3

[Marcia Knous [:marcia]]

Looks to be a duplicate of Bug 1346518 based on the crash report in Comment 2.

Comment 4

[alexander :surkov (:asurkov)]

marking as blocking bug 1346518 instead, since the crash signature may be caused by multiple independent bugs.

Comment 5

[alexander :surkov (:asurkov)]

we crash here when native root window is removed from application accessible children, since the change is not running under TreeMutation guard and such mutation changes are not allowed.

On one hand we need TreeMutation to update the sibling indices, on the other hand, TreeMutation is also used to fire events/prepare shutdown procedure, and we don't need it in document's insertion/removal case.

Comment 6

[alexander :surkov (:asurkov)]

Attachment: patch

adjusting the assertion is enough, since RemoveChild takes care to update sibling indices

Comment 7

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8853514 [details] [diff] [review]
patch

Review of attachment 8853514 [details] [diff] [review]:
-----------------------------------------------------------------

thanks

Comment 8

[alexander :surkov (:asurkov)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/95e5eab6c305c91b520ee640bdf0990afb050875
Bug 1349160 - Dismissing Print dialogue crashes Firefox, r=yzen

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/95e5eab6c305

Comment 10

[Fahima Zulfath]

The issue is no longer reproducible on Firefox Nightly 55.0a1 (build ID: 20170503030212). 
Test were performed under Windows 10x64. Browser doesn't get crashes!! 
[bugday-20170503]