Closed
Bug 1349160
Opened 7 years ago
Closed 7 years ago
Dismissing Print dialogue crashes Firefox
Categories
(Firefox :: Untriaged, defect)
Tracking
()
RESOLVED
FIXED
Firefox 55
Tracking | Status | |
---|---|---|
firefox52 | --- | unaffected |
firefox-esr52 | --- | unaffected |
firefox53 | --- | unaffected |
firefox54 | --- | unaffected |
firefox55 | --- | verified |
People
(Reporter: jtojnar, Assigned: surkov)
References
Details
(Keywords: crash, crashreportid, nightly-community)
Attachments
(1 file)
1.10 KB,
patch
|
yzen
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0 Build ID: 20170320110254 Steps to reproduce: 1. Open Print dialog. (Using both menu and keyboard short cut works.) 2. Dismiss it. (Using “Cancel” button, pressing Escape key or closing the window all work.) I have tried fresh profile. Actual results: Nightly crashes
Comment 1•7 years ago
|
||
I can't reproduce on Ubuntu 16.04 with: Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0 ID:20170320110254 CSet: 1b9293be51637f841275541d8991314ca56561a5 Can you provide a crash ID? (about:crashes)
Reporter | ||
Comment 2•7 years ago
|
||
I am on Manjaro with Openbox. > Can you provide a crash ID? (about:crashes) https://crash-stats.mozilla.com/report/index/0ec0ca19-4709-47f1-a078-f4fad2170321
Updated•7 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Whiteboard: ni
Updated•7 years ago
|
Whiteboard: ni
Comment 3•7 years ago
|
||
Looks to be a duplicate of Bug 1346518 based on the crash report in Comment 2.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
Assignee | ||
Comment 4•7 years ago
|
||
marking as blocking bug 1346518 instead, since the crash signature may be caused by multiple independent bugs.
Assignee | ||
Comment 5•7 years ago
|
||
we crash here when native root window is removed from application accessible children, since the change is not running under TreeMutation guard and such mutation changes are not allowed. On one hand we need TreeMutation to update the sibling indices, on the other hand, TreeMutation is also used to fire events/prepare shutdown procedure, and we don't need it in document's insertion/removal case.
Assignee | ||
Comment 6•7 years ago
|
||
adjusting the assertion is enough, since RemoveChild takes care to update sibling indices
Assignee: nobody → surkov.alexander
Attachment #8853514 -
Flags: review?(yzenevich)
Comment 7•7 years ago
|
||
Comment on attachment 8853514 [details] [diff] [review] patch Review of attachment 8853514 [details] [diff] [review]: ----------------------------------------------------------------- thanks
Attachment #8853514 -
Flags: review?(yzenevich) → review+
Assignee | ||
Comment 8•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/95e5eab6c305c91b520ee640bdf0990afb050875 Bug 1349160 - Dismissing Print dialogue crashes Firefox, r=yzen
Comment 9•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/95e5eab6c305
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Updated•7 years ago
|
status-firefox52:
--- → unaffected
status-firefox53:
--- → unaffected
status-firefox54:
--- → unaffected
status-firefox-esr52:
--- → unaffected
Comment 10•7 years ago
|
||
The issue is no longer reproducible on Firefox Nightly 55.0a1 (build ID: 20170503030212). Test were performed under Windows 10x64. Browser doesn't get crashes!! [bugday-20170503]
You need to log in
before you can comment on or make changes to this bug.
Description
•