Upgrade ESLint to version 3.18.0 to pick up performance and other fixes. Also update other dependencies for ESLint.

RESOLVED FIXED in Firefox 55

Status

Testing
Lint
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

Version 3
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

9 months ago
ESLint 3.18.0 has been recently released, and has included a performance improvement for hg - although we've already worked around that, it'd still be good to get that landed properly.

Additionally there's other improvements (e.g. ast selectors) that I'm going to start looking at for our rules (sometime).
(Assignee)

Comment 1

9 months ago
Created attachment 8849547 [details] [diff] [review]
Upgrade eslint patch

jryans: Can you run the update script with this patch applied please?
Flags: needinfo?(jryans)
Created attachment 8850093 [details] [diff] [review]
ESLint bundle updated for 3.18.0

Here you go!  I suggest folding this patch into yours.
Flags: needinfo?(jryans)
Comment hidden (mozreview-request)
(Assignee)

Comment 4

9 months ago
Comment on attachment 8849547 [details] [diff] [review]
Upgrade eslint patch

Thank you Ryan, I've combined the patches & pushed to mozreview. Will get a try build from there to test.
Attachment #8849547 - Attachment is obsolete: true
(Assignee)

Updated

9 months ago
Attachment #8850093 - Attachment is obsolete: true
(Assignee)

Comment 5

9 months ago
Try server push was green :-)
(Assignee)

Updated

9 months ago
Attachment #8850502 - Flags: review?(dtownsend)

Comment 6

9 months ago
mozreview-review
Comment on attachment 8850502 [details]
Bug 1349203 - Upgrade ESLint to version 3.18.0 to pick up performance and other fixes. Also update other dependencies for ESLint.

https://reviewboard.mozilla.org/r/123104/#review125526
Attachment #8850502 - Flags: review?(dtownsend) → review+

Comment 7

9 months ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a8f34abdc1fb
Upgrade ESLint to version 3.18.0 to pick up performance and other fixes. Also update other dependencies for ESLint. r=mossop

Comment 8

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a8f34abdc1fb
Status: NEW → RESOLVED
Last Resolved: 9 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.