Closed Bug 1349203 Opened 3 years ago Closed 3 years ago

Upgrade ESLint to version 3.18.0 to pick up performance and other fixes. Also update other dependencies for ESLint.

Categories

(Firefox Build System :: Lint and Formatting, enhancement)

3 Branch
enhancement
Not set

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: standard8, Assigned: standard8)

Details

Attachments

(1 file, 2 obsolete files)

ESLint 3.18.0 has been recently released, and has included a performance improvement for hg - although we've already worked around that, it'd still be good to get that landed properly.

Additionally there's other improvements (e.g. ast selectors) that I'm going to start looking at for our rules (sometime).
Attached patch Upgrade eslint patch (obsolete) — Splinter Review
jryans: Can you run the update script with this patch applied please?
Flags: needinfo?(jryans)
Attached patch ESLint bundle updated for 3.18.0 (obsolete) — Splinter Review
Here you go!  I suggest folding this patch into yours.
Flags: needinfo?(jryans)
Comment on attachment 8849547 [details] [diff] [review]
Upgrade eslint patch

Thank you Ryan, I've combined the patches & pushed to mozreview. Will get a try build from there to test.
Attachment #8849547 - Attachment is obsolete: true
Attachment #8850093 - Attachment is obsolete: true
Try server push was green :-)
Attachment #8850502 - Flags: review?(dtownsend)
Comment on attachment 8850502 [details]
Bug 1349203 - Upgrade ESLint to version 3.18.0 to pick up performance and other fixes. Also update other dependencies for ESLint.

https://reviewboard.mozilla.org/r/123104/#review125526
Attachment #8850502 - Flags: review?(dtownsend) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a8f34abdc1fb
Upgrade ESLint to version 3.18.0 to pick up performance and other fixes. Also update other dependencies for ESLint. r=mossop
https://hg.mozilla.org/mozilla-central/rev/a8f34abdc1fb
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Product: Testing → Firefox Build System
Version: Version 3 → 3 Branch
You need to log in before you can comment on or make changes to this bug.