1349237 - Tweaks to the graphql integration

Status: RESOLVED FIXED

(Tree Management :: Treeherder, enhancement, P3)

Description

[Ed Morley [:emorley]]

I spotted a few things in the bug 1332457 PRs:
* Both django-graphiql and graphene-django are installed/set up, when the latter is apparently deprecated (see repo description at https://github.com/graphql-python/django-graphiql)
* The pytest/py packages are actually unused (and the pytest one is actually a dupe of dev.txt)

Is there a reason why we're using both django-graphiql and graphene-django? :-)

Also, were we going to set the environment variable to enable it on stage?

Comment 1

[GitHub Autolander Bot]

Attachment: [treeherder] SebastinSanty:gql > mozilla:master

Comment 2

[Sebastin Santy [:seban]]

Hi Ed,

graphiql (which is infact deprecated) isn't needed as it is already there in graphene-django. Thanks for pointing this out :-). I have made the necessary changes.

Comment 3

[Ed Morley [:emorley]]

I have left some comments on the PR :-)

Comment 4

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/74b727a2e8e0b4e7307e671040c55cfab9a3ce2f
Bug 1349237 - Tweaks to the graphql integration (#2275)

Comment 5

[William Lachance (:wlach)]

Comment on attachment 8849636 [details] [review]
[treeherder] SebastinSanty:gql > mozilla:master

r+'ing