Closed
Bug 1349239
Opened 9 years ago
Closed 9 years ago
Add pytest suite for hg staging server
Categories
(Conduit :: General, enhancement)
Conduit
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: davidwalsh, Assigned: davidwalsh)
Details
Attachments
(2 files)
Should be much like changeset 41108a19c22d
Acceptance criteria:
`pytest` is registered when /bin/sh'ing into hg staging server
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 5•9 years ago
|
||
| mozreview-review | ||
Comment on attachment 8849616 [details]
staginghg: Add pytest to the staginghgserver environment. (Bug 1349239).
https://reviewboard.mozilla.org/r/122408/#review124550
::: commit-message-933f4:1
(Diff revision 2)
> +Conduit: Add pytest to the staginghgserver environment. (Bug 1349239). r?mars
The component at the start of the summary line should be "staginghg:" instead of "Conduit:"
::: staginghgserver/docker/Dockerfile:22
(Diff revision 2)
>
> VOLUME ["/repos"]
>
> EXPOSE 8080
>
> -ENTRYPOINT ["/entrypoint.sh"]
> +CMD cd /repos && exec hg serve --port 8080 --web-conf ${HG_WEB_CONF}
Instead of "cd /repos &&" you could set "WORKDIR /repos" on the line above - then CMD would already be in the right directory.
Attachment #8849616 -
Flags: review?(mars) → review-
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
||
Comment 8•9 years ago
|
||
| mozreview-review | ||
Comment on attachment 8849616 [details]
staginghg: Add pytest to the staginghgserver environment. (Bug 1349239).
https://reviewboard.mozilla.org/r/122408/#review124586
::: staginghgserver/docker/Dockerfile:23
(Diff revision 3)
> VOLUME ["/repos"]
>
> EXPOSE 8080
>
> -ENTRYPOINT ["/entrypoint.sh"]
> +WORKDIR /repos
> +CMD exec hg serve --port 8080 --web-conf ${HG_WEB_CONF}
According to the [docker docs for CMD](https://docs.docker.com/engine/reference/builder/#cmd) this might be able to use the "exec" form of the CMD statement:
```
CMD ["/usr/bin/hg", "serve", "--port", "8080", "--web-conf", "${HG_WEB_CONF}"]
```
Does that work?
Attachment #8849616 -
Flags: review?(mars) → review-
|
|
||
Comment 9•9 years ago
|
||
| mozreview-review | ||
Comment on attachment 8849617 [details]
staginghg: Update conduitdemo docker paths to be more like staginghgserver (Bug 1349239)
https://reviewboard.mozilla.org/r/122410/#review124588
Attachment #8849617 -
Flags: review+
|
|
||
Comment 10•9 years ago
|
||
| mozreview-review-reply | ||
Comment on attachment 8849616 [details]
staginghg: Add pytest to the staginghgserver environment. (Bug 1349239).
https://reviewboard.mozilla.org/r/122408/#review124586
> According to the [docker docs for CMD](https://docs.docker.com/engine/reference/builder/#cmd) this might be able to use the "exec" form of the CMD statement:
>
> ```
> CMD ["/usr/bin/hg", "serve", "--port", "8080", "--web-conf", "${HG_WEB_CONF}"]
> ```
>
> Does that work?
David reports that it doesn't work, so I'm dropping this.
|
|
||
Comment 11•9 years ago
|
||
| mozreview-review | ||
Comment on attachment 8849616 [details]
staginghg: Add pytest to the staginghgserver environment. (Bug 1349239).
https://reviewboard.mozilla.org/r/122408/#review124610
Attachment #8849616 -
Flags: review- → review+
|
||
Comment 12•9 years ago
|
||
Pushed by mfogels@mozilla.com:
https://hg.mozilla.org/automation/conduit/rev/7a1e7dc203f7
staginghg: Add pytest to the staginghgserver environment. . r=mars
https://hg.mozilla.org/automation/conduit/rev/cea6f6bc396f
staginghg: Update conduitdemo docker paths to be more like staginghgserver r=mars
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
|
||
Updated•9 years ago
|
Assignee: nobody → dwalsh
You need to log in
before you can comment on or make changes to this bug.
Description
•