1349250 - Requesting /iterations/<id> for a non-existent iteration should return a 404

Status: RESOLVED FIXED

(Conduit :: General, enhancement)

Comment 1

[Steven MacLeod [:smacleod]]

Attachment: commit-index: make iterations/{id} always 404 (bug 1349250).

Since we don't have actual persistent iterations yet we'll start
this endpoint functionality with the 404 response.

Review commit: https://reviewboard.mozilla.org/r/122398/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/122398/

Comment 2

[Steven MacLeod [:smacleod]]

Comment on attachment 8849608 [details]
commit-index: make iterations/{id} always 404 (bug 1349250).

https://reviewboard.mozilla.org/r/122398/#review124518

::: commitindex/commitindex/api/iterations.py:21
(Diff revision 1)
> +    # We could not find a matching iteration.
> +    return problem(
> +        404,
> +        'Iteration not found',
> +        'The requested iteration does not exist',
> +        type='https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/404')

I couldn't decide between this current descriptive url, or the less descriptive spec url: "https://tools.ietf.org/html/rfc7231#section-6.5.4"... The other option is actually creating error pages to describe our specific unique errors, but I think a 404 is pretty self describing.

Comment 3

[Steven MacLeod [:smacleod]]

Comment on attachment 8849608 [details]
commit-index: make iterations/{id} always 404 (bug 1349250).

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/122398/diff/1-2/

Comment 4

[David Walsh :davidwalsh]

Comment on attachment 8849608 [details]
commit-index: make iterations/{id} always 404 (bug 1349250).

https://reviewboard.mozilla.org/r/122398/#review124562

- Started `commitindex`
- Opened new terminal, ssh'd into `commitindex`
- `http://commitindex:8888/iterations/222`
- Results in:

```
{
  "detail": "The requested iteration does not exist",
  "status": 404,
  "title": "Iteration not found",
  "type": "https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/404"
}
```

Code looks good to me!

Comment 5

[David Lawrence [:dkl]]

Comment on attachment 8849608 [details]
commit-index: make iterations/{id} always 404 (bug 1349250).

https://reviewboard.mozilla.org/r/122398/#review124646

Looks great and works as expected. r=dkl

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/automation/conduit/rev/48982f7f928b
commit-index: make iterations/{id} always 404 . r=davidwalsh,dkl