1349292 - In a contenteditable document, button element doesn't work as it should.

Status: NEW

(Core :: DOM: Editor, defect, P3)

Description

[Tony Duffill]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36

Steps to reproduce:

Created a Button element in a contenteditable document.


Actual results:

The Button element is not editable - even enclosing it in a Span with contenteditable="false", and setting the Button itself to contenteditable="true" only made it partially editable - the problem being that images or spans within the Button element weren't correctly detected (event.target always returns Button, even if you click on an image or span).


Expected results:

It should work like in every other modern web browser and be genuinely editable.

Comment 1

[Loic]

Could you provide a testcase, please.

Comment 2

[Tony Duffill]

Attachment: formTest.htm

Images in attached file won't work...

But concentrate on the Button element:

It mostly works (but only if contained within a Span with contenteditable="false" - try removing the Span!!)

BUT - even if you click on the span inside the Button, event.target returns 'Button' - images are similarly not recognised, if you can introduce one.

Many thanks

Tony

Comment 3

[Makoto Kato [:m_kato]]

Although the behavior is different to Blink, I cannot find spec for correct behavior.

This seems to be event target.  If this should handle editor, you can back to editor.

Comment 4

[Andrew Overholt [:overholt]]

Stone, can you determine where we're going wrong here (if we are)? Thanks!

Comment 5

[Ming-Chou Shih [:stone]]

Looks like we didn't support 'contenteditable' for button element. Did hit test and always got the button element as the event target.

Comment 6

[Ming-Chou Shih [:stone]]

(In reply to Ming-Chou Shih [:stone] from comment #5)
> Looks like we didn't support 'contenteditable' for button element. Did hit
> test and always got the button element as the event target.

Can't find the spec says that button element does not support contenteditable and can't find the spec says the children of button element are anonymous to users neither.

Also tested it on Edge and it behaved the same as Chrome.

Comment 7

[Andrew Overholt [:overholt]]

(In reply to Ming-Chou Shih [:stone] from comment #6)
> (In reply to Ming-Chou Shih [:stone] from comment #5)
> > Looks like we didn't support 'contenteditable' for button element. Did hit
> > test and always got the button element as the event target.
> 
> Can't find the spec says that button element does not support
> contenteditable and can't find the spec says the children of button element
> are anonymous to users neither.

Maybe Anne can help?

Comment 8

[Anne (:annevk)]

Hit testing is bug 1089326.

For contenteditable I recommend we try to match the other browsers (or at least a majority of them). There's some standardization effort going on, but it's not based on thousands of tests so I'm not convinced it's going to be very useful.

Comment 9

[Andrew Overholt [:overholt]]

(In reply to Anne (:annevk) from comment #8)
> 
> For contenteditable I recommend we try to match the other browsers

So this is more of a Core::Editor thing?

Comment 10

[Sylvestre Ledru [:Sylvestre]]

Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information