1349307 - Intermittent browser/base/content/test/static/browser_all_files_referenced.js | application crashed [@ libxul.so + 0x3622cf] after Assertion failure: [unhandlable oom] Failed to allocate object while tenuring., at jscntxt.cpp:1502

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Treeherder Bug Filer]

Filed by: wkocher [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=85394773&repo=autoland

https://queue.taskcluster.net/v1/task/YyojMSphTbeLUKs52XYzlg/runs/0/artifacts/public/logs/live_backing.log

Comment 1

[Phil Ringnalda (:philor)]

This doesn't actually seem to be intermittent on m-c's linux32 nightly tests, it seems to be permaorange there.

Comment 2

[Florian Quèze [:florian]]

(In reply to Phil Ringnalda (:philor) from comment #1)
> This doesn't actually seem to be intermittent on m-c's linux32 nightly
> tests, it seems to be permaorange there.

It's fine to disable this test on linux32 as long as we keep it enabled on linux64, so feel free to go ahead and do that (or I'll likely do it in the next few days).

Comment 3

[Intermittent Failures Robot]

22 failures in 898 pushes (0.024 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* mozilla-central: 14
* mozilla-inbound: 3
* autoland: 3
* try: 1
* graphics: 1

Platform breakdown:
* linux32-nightly: 13
* linux32: 9

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1349307&startday=2017-03-20&endday=2017-03-26&tree=all

Comment 4

[Florian Quèze [:florian]]

Attachment: disable on linux32

I don't think this really needs review, but probably doesn't hurt to have someone rs it.

Comment 5

[:Gijs (out for now; he/him)]

Comment on attachment 8851526 [details] [diff] [review]
disable on linux32

Review of attachment 8851526 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/test/static/browser.ini
@@ +2,5 @@
>  support-files =
>    head.js
>  
>  [browser_all_files_referenced.js]
> +skip-if = debug || (os == 'linux' && bits == 32) # no point in running on both opt and debug, and will likely intermittently timeout on debug; oom crashes on linux32 (bug 1349307)

I wonder if, at this point, we should just add this skip-if in the [default] section (and remove the remaining skip-ifs).

rs=me either way.

Comment 6

[Florian Quèze [:florian]]

Attachment: disable static/ tests for debug builds

So I'm tempted to disable the whole test folder for debug builds with the attached patch, because it doesn't seem very useful to run these tests both on opt and debug, but bug 1065446 makes me think others may not agree.

Or did you mean disable the whole folder for linux32 because we already have linux64 coverage so linux32 doesn't matter?

Comment 7

[:Gijs (out for now; he/him)]

(In reply to Florian Quèze [:florian] [:flo] from comment #6)
> Created attachment 8851533 [details] [diff] [review]
> disable static/ tests for debug builds
> 
> So I'm tempted to disable the whole test folder for debug builds with the
> attached patch, because it doesn't seem very useful to run these tests both
> on opt and debug, but bug 1065446 makes me think others may not agree.
> 
> Or did you mean disable the whole folder for linux32 because we already have
> linux64 coverage so linux32 doesn't matter?

I meant disabling the entire thing on both debug and on linux32.

I don't know if you can "and" skip-ifs like this (ie I'm not sure the result would be skipping the all_files_referenced test on debug or not). I recall it being extra work to make support-files work the 'right' way...

Comment 8

[Florian Quèze [:florian]]

(In reply to :Gijs from comment #7)

> I don't know if you can "and" skip-ifs like this (ie I'm not sure the result
> would be skipping the all_files_referenced test on debug or not). I recall
> it being extra work to make support-files work the 'right' way...

Ok, then if it's not straightforward, I'll keep the existing logic for the other tests, and just go with the simplest change you r+'ed. Thanks!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/11bc569ff6ad
disable browser_all_files_referenced.js on linux32 where it causes oom crashes, rs=Gijs.

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/11bc569ff6ad