1349335 - Use the grid colours for the grid cell and area fills

Status: VERIFIED FIXED

(DevTools :: Inspector, defect, P3)

Description

[Gabriel Luong [:gl] (ΦωΦ)]

The fill color for the grid cell and area highlights should follow the design spec.

Comment 1

[Micah Tigley [:micah]]

Attachment: Bug 1349335 - Use new colours for the grid cell and area fills.

Review commit: https://reviewboard.mozilla.org/r/145082/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/145082/

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8873687 [details]
Bug 1349335 - Use new colours for the grid cell and area fills.

https://reviewboard.mozilla.org/r/145082/#review149242

Comment 3

[Micah Tigley [:micah]]

Comment on attachment 8873687 [details]
Bug 1349335 - Use new colours for the grid cell and area fills.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/145082/diff/1-2/

Comment 4

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8873687 [details]
Bug 1349335 - Use new colours for the grid cell and area fills.

https://reviewboard.mozilla.org/r/145082/#review149732

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/337dfcb8c30a
Use the grid color for the grid cell and area fills. r=gl

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/337dfcb8c30a

Comment 7

[Bogdan Maris, Desktop QA]

Hello Micah. Does the fix affect the grid outline (that box model of the grid area from a webpage inside Layout)? I'm trying to figure out what to verify here.

Comment 8

[Micah Tigley [:micah]]

(In reply to Bogdan Maris, QA [:bogdan_maris] from comment #7)
> Hello Micah. Does the fix affect the grid outline (that box model of the
> grid area from a webpage inside Layout)? I'm trying to figure out what to
> verify here.

Hello! This fix affects the grid highlighter on the webpage and not the grid outline inside the Layout panel. When you hover over a grid cell in the grid outline, you should expect the highlighted cell's fill colour to be the same as the current colour palette of the grid (but transparent).

Comment 9

[Bogdan Maris, Desktop QA]

(In reply to Micah Tigley [:micah] from comment #8)
> (In reply to Bogdan Maris, QA [:bogdan_maris] from comment #7)
> > Hello Micah. Does the fix affect the grid outline (that box model of the
> > grid area from a webpage inside Layout)? I'm trying to figure out what to
> > verify here.
> 
> Hello! This fix affects the grid highlighter on the webpage and not the grid
> outline inside the Layout panel. When you hover over a grid cell in the grid
> outline, you should expect the highlighted cell's fill colour to be the same
> as the current colour palette of the grid (but transparent).

Thanks!

Confirming that this issues is verified fixed based on the testing done during pre-Beta signoff and testing done by me today using Fx 55.0 build 3 (after enabling 'devtools.gridinspector.showGridOutline' and 'devtools.layoutview.enabled') across platforms (Windows 10 64bit, macOS 10.12.5 and Ubuntu 16.04 32bit).