1349350 - IPDL compiler doesn't error out when it finds sync-messages.ini entries without corresponding IPDL sync messages

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Eric Rahm [:erahm]]

Bug 1345111 added what should have been a fatal IPDL build error, but it just dumps log spam instead. Example snippet from a build log from a windows build [1]:

> 16:32:03     INFO -  Error: Sync IPC message PDocAccessible::RowIdx not found, it appears to be fixed.
> 16:32:03     INFO -  Please remove it from sync-messages.ini.
> 16:32:03     INFO -  Error: Sync IPC message PDocAccessible::TableSelectRow not found, it appears to be fixed.
> 16:32:03     INFO -  Please remove it from sync-messages.ini.

[1] https://treeherder.mozilla.org/logviewer.html#?job_id=85372495&repo=mozilla-central&lineNumber=3310-3549

Comment 1

[Eric Rahm [:erahm]]

Attachment: Make IPDL checker sync IPC message errors fatal

The IPDL sync IPC message error checker needs to actually return a result and
exit if it fails.

Ehsan, I think this fixes the checker but I'm not sure how we're supposed to
fix the build errors it's going to cause.

MozReview-Commit-ID: 1ZAuAWRlsvk

Comment 2

[Andrew McCreight [:mccr8]]

(In reply to Eric Rahm [:erahm] from comment #1)
> Ehsan, I think this fixes the checker but I'm not sure how we're supposed to
> fix the build errors it's going to cause.

You just add a platform= entry for it. That suppresses the error.

Comment 3

[Andrew McCreight [:mccr8]]

This is sort of a dupe of bug 1347000, if you are going to fix those errors.

Comment 4

[Eric Rahm [:erahm]]

(In reply to Andrew McCreight [:mccr8] from comment #3)
> This is sort of a dupe of bug 1347000, if you are going to fix those errors.

I posted a patch for the errors there, we can fix the lack of build failure here.

Comment 5

[Eric Rahm [:erahm]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d9ccdd50ed52

Comment 6

[Eric Rahm [:erahm]]

(In reply to Eric Rahm [:erahm] from comment #5)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=d9ccdd50ed52

This push was with the error checking fix, I expect the build to fail. The following push fixes the platform dependent messages, I expect it to pass:
    https://bugzilla.mozilla.org/show_bug.cgi?id=1347000

Comment 7

[(no longer active)]

Comment on attachment 8849727 [details] [diff] [review]
Make IPDL checker sync IPC message errors fatal

Review of attachment 8849727 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you!

Comment 8

[Eric Rahm [:erahm]]

Attachment: Make IPDL checker sync IPC message errors fatal

Had the error condition inverted, fixed up now.

Comment 9

[Eric Rahm [:erahm]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6fefbc42635e

Comment 10

[Eric Rahm [:erahm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/59efeb9e45a38e39ae6c30c094f04e8cc62f73fb
Bug 1349350 - Make IPDL checker sync IPC message errors fatal. r=ehsan

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/59efeb9e45a3