1349354 - Remove experimental SourceMapService (uses server-side source map support)

Status: RESOLVED FIXED

(DevTools :: General, enhancement, P3)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

In bug 670002, an experimental `SourceMapService` was added.

The current state:

* The service is off by default because of perf issues (bug 1289570)
* This service uses server-side source map support
* It's only used in the console (old and new)

We're working towards client-side source maps, so we'll eventually want to remove this approach.

Comment 1

[Tom Tromey :tromey]

Let's not forget to remove the client side code that will be obsolete:
location-store.js and source-map-service.js.

Comment 2

[Tom Tromey :tromey]

And resolveLocation in target.js, and the code in the tab actor, and likewise TabClient.

Comment 4

[Tom Tromey :tromey]

It's unclear if some of the existing server-side code is still in use.
Certainly the style sheet code is.
I think it's advisable to start with what's obviously unused and then
delete more in a later bug.

Comment 5

[Tom Tromey :tromey]

Attachment: Bug 1349354 - remove now-unused source-map-service;

Review commit: https://reviewboard.mozilla.org/r/139290/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/139290/

Comment 6

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8867715 [details]
Bug 1349354 - remove now-unused source-map-service;

https://reviewboard.mozilla.org/r/139290/#review142596

Great, looks like you've removed everything that can be removed for now.  For the server-side source mapping support in general, I'd say that should remain in place until the old debugger is removed, but I'm sure other arguments could be made...

Comment 7

[Tom Tromey :tromey]

Yeah, from my reading it requires removing the old debugger (or updating that to the client-side service)
as well as parts of the inspector.
I'll file a follow-up.

Comment 8

[Tom Tromey :tromey]

Comment on attachment 8867715 [details]
Bug 1349354 - remove now-unused source-map-service;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/139290/diff/1-2/

Comment 9

[Tom Tromey :tromey]

Comment on attachment 8867715 [details]
Bug 1349354 - remove now-unused source-map-service;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/139290/diff/2-3/

Comment 10

[Tom Tromey :tromey]

eslint found an unused variable.

Comment 11

[Tom Tromey :tromey]

The source-map-url-service.js change was wrong - I think I misunderstood the situation when I wrote
that module initially, since what is really happening is that generatedUrl is first computed by
SpiderMonkey during parsing, then given to us via the actor.  This isn't something we'll ever be
removing.  So, my next patch will just update the comment there.

Comment 12

[Tom Tromey :tromey]

Comment on attachment 8867715 [details]
Bug 1349354 - remove now-unused source-map-service;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/139290/diff/3-4/

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fcc8c00308a1
remove now-unused source-map-service; r=jryans

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/fcc8c00308a1