1349407 - Building Docker images is slow due to rsync

Status: RESOLVED FIXED

(MozReview Graveyard :: Testing / Development Environment, defect)

Description

[Gregory Szorc [:gps]]

Patch forthcoming.

Comment 1

[Gregory Szorc [:gps]]

Attachment: testing: rsync from server instead of volume (bug 1349407);

For reasons that I can only attribute to "because Docker," building
Ansible Docker images is now extremely slow on my desktop. I tracked
this down to `rsync` being *extremely* slow. It was rsyncing between
a mounted Docker volume from another container and a local volume. I
put processes under `strace` and it revealed a number of lstat() and
lchown() calls. But they were extremely slow - milliseconds instead of
microseconds. I have no clue why this is or what changed to make this
slow. I'm using overlay2 if it matters.

Fortunately, there is a workaround which appears to fix the problem.

This commit switches the rsync from using a local volume to using the
rsync server running on the vct container. This makes rsync fast
again.

Various clobber.* files were touched to force the Docker images to be
rebuilt from scratch on next build. This is necessary to pick up
changes to the sync-and-build files from the base Docker image.

Review commit: https://reviewboard.mozilla.org/r/122538/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/122538/

Comment 2

[:glob ✱]

Comment on attachment 8849786 [details]
testing: rsync from server instead of volume (bug 1349407);

https://reviewboard.mozilla.org/r/122538/#review124758

lgtm

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/c77d8797d0ad
testing: rsync from server instead of volume ; r=glob

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/63f19cfacc5c
docker: stop using `rsync -a` because owner/group updates are slow on overlayfs