1349415 - Pass Connection data into NetmonitorController to support run on both toolbar and browser tab

Status: RESOLVED FIXED

(DevTools :: Netmonitor, enhancement, P1)

Description

[[e-mail]]

In experiment branch, with this small modification, we can use same NetmonitorController to run on both toolbar and browser tab 

https://github.com/gasolin/devtools-core/blob/netmonitor.html/packages/netmonitor/src/netmonitor-controller.js#L94

Comment 1

[[e-mail]]

The corespondent caller function in main.js (to run on browser tab with webpack's help) is `NetMonitorController.startupNetMonitor(connection);`

https://github.com/gasolin/devtools-core/blob/netmonitor.html/packages/netmonitor/src/main.js#L67

Comment 2

[[e-mail]]

Attachment: Bug 1349415 - Pass Connection data into NetmonitorController to run on both toolbar and browser tab;

Review commit: https://reviewboard.mozilla.org/r/122560/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/122560/

Comment 3

[[e-mail]]

Comment on attachment 8849802 [details]
Bug 1349415 - Pass Connection data into NetmonitorController to run on both toolbar and browser tab;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/122560/diff/1-2/

Comment 4

[[e-mail]]

Comment on attachment 8849802 [details]
Bug 1349415 - Pass Connection data into NetmonitorController to run on both toolbar and browser tab;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/122560/diff/2-3/

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8849802 [details]
Bug 1349415 - Pass Connection data into NetmonitorController to run on both toolbar and browser tab;

https://reviewboard.mozilla.org/r/122560/#review126750

Comment 6

[[e-mail]]

thanks!

Comment 7

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s ff9da01455df -d 405c692a053a: rebasing 385598:ff9da01455df "Bug 1349415 - Pass Connection data into NetmonitorController to run on both toolbar and browser tab;r=Honza" (tip)
merging devtools/client/netmonitor/netmonitor-controller.js
warning: conflicts while merging devtools/client/netmonitor/netmonitor-controller.js! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 8

[[e-mail]]

Comment on attachment 8849802 [details]
Bug 1349415 - Pass Connection data into NetmonitorController to run on both toolbar and browser tab;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/122560/diff/3-4/

Comment 9

[[e-mail]]

Comment on attachment 8849802 [details]
Bug 1349415 - Pass Connection data into NetmonitorController to run on both toolbar and browser tab;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/122560/diff/4-5/

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/85d3f9ef8997
Pass Connection data into NetmonitorController to run on both toolbar and browser tab;r=Honza

Comment 11

[Mozilla Autoland]

We're sorry - something has gone wrong while rewriting or rebasing your commits. The commits being pushed no longer match what was requested. Please file a bug.

Comment 12

[[e-mail]]

hmm, seems I have to wait for bug 1350215 land

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/85d3f9ef8997