1349464 - Bug filer fails to open sometimes from autoclassify panel.

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Some jobs[1] don't have a log file ending in "_json", so https://github.com/mozilla/treeherder/blob/8e56de8590f9a085d2e77ba2279f243dfdbad1a5/ui/plugins/auto_classification/controller.js#L151 sometimes silently throws an error trying to access the first item in an empty array, causing the bug filer to fail to open.



1. Like these https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&bugfiler&fromchange=0e6b4d237ef6732d19240dde3b4fa9ac1d1d61aa&filter-searchStr=en-us&selectedJob=85253723

Comment 1

[GitHub Autolander Bot]

Attachment: [treeherder] KWierso:autoclassifyfiler > mozilla:master

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Comment on attachment 8849876 [details] [review]
[treeherder] KWierso:autoclassifyfiler > mozilla:master

This should hopefully catch the previously failing case and just take the first log from the ctrl.thJob.logs array, regardless of it ending in _json. 

This ends up being the same log that is used for this property from the failure summary panel, so no huge loss in using it.

Comment 3

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/9abb507d4d30f4c70c04c222b32b754127196579
Bug 1349464 - Deal with jobs that don't have _json-ending logs (#2282) r=jgraham