Closed Bug 1349465 Opened 3 years ago Closed 3 years ago

Fix gpu process disable handling in gfxWindowsPlatform::InitGPUProcessSupport()

Categories

(Core :: Graphics: WebRender, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: sotaro, Assigned: sotaro)

References

Details

Attachments

(1 file, 1 obsolete file)

WebRender is enabled only when Gpu process is enabled. But on windows, gpu process could be disabled in gfxWindowsPlatform::InitGPUProcessSupport(). It is called after gfxPlatform::InitWebRenderConfig().
Blocks: 1323316
Assignee: nobody → sotaro.ikeda.g
Attachment #8849883 - Flags: review?(bugmail)
Comment on attachment 8849883 [details] [diff] [review]
patch - Fix gpu process disable handling in gfxWindowsPlatform::InitGPUProcessSupport()

It might be better to defer webrender decision than this patch.
Attachment #8849883 - Flags: review?(bugmail)
Attachment #8849883 - Attachment is obsolete: true
Attachment #8849951 - Flags: review?(bugmail)
Comment on attachment 8849951 [details] [diff] [review]
patch - Fix gpu process disable handling

Review of attachment 8849951 [details] [diff] [review]:
-----------------------------------------------------------------

Patch looks fine, but the commit message is no good. Please use something like this:

Bug 1349465 - Ensure we don't enable WebRender if the GPU process is disabled.

gfxWindowsPlatform overrides InitAcceleration, and the override calls
InitGPUProcessSupport, which may disable the GPU process. Therefore, in
order to capture this scenario, we need to initialize WebRender after
the subclass implementation has run, rather than at the end of the base
class implementation, which is before InitGPUProcessSupport has run.
Attachment #8849951 - Flags: review?(bugmail) → review+
Thanks for the advice!
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/436d2138f6fa
Ensure we don't enable WebRender if the GPU process is disabled r=kats
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.