1349465 - Fix gpu process disable handling in gfxWindowsPlatform::InitGPUProcessSupport()

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Sotaro Ikeda [:sotaro]]

WebRender is enabled only when Gpu process is enabled. But on windows, gpu process could be disabled in gfxWindowsPlatform::InitGPUProcessSupport(). It is called after gfxPlatform::InitWebRenderConfig().

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Fix gpu process disable handling in gfxWindowsPlatform::InitGPUProcessSupport()

Comment 2

[Sotaro Ikeda [:sotaro]]

Comment on attachment 8849883 [details] [diff] [review]
patch - Fix gpu process disable handling in gfxWindowsPlatform::InitGPUProcessSupport()

It might be better to defer webrender decision than this patch.

Comment 3

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Fix gpu process disable handling

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8849951 [details] [diff] [review]
patch - Fix gpu process disable handling

Review of attachment 8849951 [details] [diff] [review]:
-----------------------------------------------------------------

Patch looks fine, but the commit message is no good. Please use something like this:

Bug 1349465 - Ensure we don't enable WebRender if the GPU process is disabled.

gfxWindowsPlatform overrides InitAcceleration, and the override calls
InitGPUProcessSupport, which may disable the GPU process. Therefore, in
order to capture this scenario, we need to initialize WebRender after
the subclass implementation has run, rather than at the end of the base
class implementation, which is before InitGPUProcessSupport has run.

Comment 5

[Sotaro Ikeda [:sotaro]]

Thanks for the advice!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/436d2138f6fa
Ensure we don't enable WebRender if the GPU process is disabled r=kats

Comment 7

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/mozilla-central/rev/436d2138f6fa