Closed Bug 1349477 Opened 7 years ago Closed 7 years ago

Use AutoReferenceChainGuard to protect against SVG reference loops and long reference chains

Categories

(Core :: SVG, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: jwatt, Assigned: jwatt)

References

Details

Attachments

(4 files)

Scattered about some SVG frame classes we have frame specific code to protect against reference loops. We should convert those frame classes to use AutoReferenceChainGuard. In addition to breaking loops this will give us added protection against long reference chains, will report to the devtools console any loops and long chains that we break, and allows us to reuse code.
Assignee: nobody → jwatt
Attachment #8849897 - Flags: review?(longsonr)
Attachment #8849898 - Flags: review?(longsonr)
Depends on: 1349388
Attachment #8849897 - Flags: review?(longsonr) → review+
Attachment #8849898 - Flags: review?(longsonr) → review+
Attachment #8850200 - Flags: review?(longsonr) → review+
Attachment #8850201 - Flags: review?(longsonr) → review+
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a9899b06e057
part 1 - Use AutoReferenceChainGuard in nsSVGFilterFrame. r=longsonr
https://hg.mozilla.org/integration/mozilla-inbound/rev/eaefc6e6d5f1
part 2 - Use AutoReferenceChainGuard in nsSVGGradientFrame. r=longsonr
https://hg.mozilla.org/integration/mozilla-inbound/rev/b08dbe8010f5
part 3 - Use AutoReferenceChainGuard in nsSVGPatternFrame. r=longsonr
https://hg.mozilla.org/integration/mozilla-inbound/rev/b94159328bef
part 4 - Use AutoReferenceChainGuard in nsSVGMaskFrame. r=longsonr
Depends on: 1392235
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: