Closed
Bug 1349477
Opened 7 years ago
Closed 7 years ago
Use AutoReferenceChainGuard to protect against SVG reference loops and long reference chains
Categories
(Core :: SVG, enhancement)
Core
SVG
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: jwatt, Assigned: jwatt)
References
Details
Attachments
(4 files)
7.29 KB,
patch
|
longsonr
:
review+
|
Details | Diff | Splinter Review |
10.16 KB,
patch
|
longsonr
:
review+
|
Details | Diff | Splinter Review |
10.86 KB,
patch
|
longsonr
:
review+
|
Details | Diff | Splinter Review |
3.55 KB,
patch
|
longsonr
:
review+
|
Details | Diff | Splinter Review |
Scattered about some SVG frame classes we have frame specific code to protect against reference loops. We should convert those frame classes to use AutoReferenceChainGuard. In addition to breaking loops this will give us added protection against long reference chains, will report to the devtools console any loops and long chains that we break, and allows us to reuse code.
Assignee | ||
Comment 1•7 years ago
|
||
Assignee: nobody → jwatt
Attachment #8849897 -
Flags: review?(longsonr)
Assignee | ||
Comment 2•7 years ago
|
||
Attachment #8849898 -
Flags: review?(longsonr)
Updated•7 years ago
|
Attachment #8849897 -
Flags: review?(longsonr) → review+
Updated•7 years ago
|
Attachment #8849898 -
Flags: review?(longsonr) → review+
Assignee | ||
Comment 3•7 years ago
|
||
Attachment #8850200 -
Flags: review?(longsonr)
Assignee | ||
Comment 4•7 years ago
|
||
Attachment #8850201 -
Flags: review?(longsonr)
Updated•7 years ago
|
Attachment #8850200 -
Flags: review?(longsonr) → review+
Updated•7 years ago
|
Attachment #8850201 -
Flags: review?(longsonr) → review+
Pushed by jwatt@jwatt.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/a9899b06e057 part 1 - Use AutoReferenceChainGuard in nsSVGFilterFrame. r=longsonr https://hg.mozilla.org/integration/mozilla-inbound/rev/eaefc6e6d5f1 part 2 - Use AutoReferenceChainGuard in nsSVGGradientFrame. r=longsonr https://hg.mozilla.org/integration/mozilla-inbound/rev/b08dbe8010f5 part 3 - Use AutoReferenceChainGuard in nsSVGPatternFrame. r=longsonr https://hg.mozilla.org/integration/mozilla-inbound/rev/b94159328bef part 4 - Use AutoReferenceChainGuard in nsSVGMaskFrame. r=longsonr
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a9899b06e057 https://hg.mozilla.org/mozilla-central/rev/eaefc6e6d5f1 https://hg.mozilla.org/mozilla-central/rev/b08dbe8010f5 https://hg.mozilla.org/mozilla-central/rev/b94159328bef
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•