Closed Bug 1349483 Opened 3 years ago Closed 2 years ago

Eyedropper doesn't work to change the color of a node when toolbox is undocked

Categories

(DevTools :: Inspector, defect, P2)

54 Branch
defect

Tracking

(firefox-esr52 unaffected, firefox57 wontfix, firefox58 wontfix, firefox59 fixed)

RESOLVED FIXED
Firefox 59
Tracking Status
firefox-esr52 --- unaffected
firefox57 --- wontfix
firefox58 --- wontfix
firefox59 --- fixed

People

(Reporter: stein, Assigned: jdescottes)

References

Details

(Keywords: regression)

Attachments

(4 files)

Attached file Doc1.docx
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:54.0) Gecko/20100101 Firefox/54.0
Build ID: 20170320004004

Steps to reproduce:

Currently using the Developer Edition, but the normal Firefox has the same issues

- Open "Inspect Element"
- Click "Show in separate window"
Issue 1 & 2:
- Type color or anyother property that could trigger the Color picking tool in "Rules". - Type a color, for example red and click on the red circle to activate the Color picking tool.
- Issue 1: slide the transparency bar < Normally this would translate to for example: rgba(0,0,0,.9). This isn't the case here as it translates to a weird color. This is issue exists for the "Docked" version as well. 
- Issue2: Click on the pipette like looking thing.
- Pick a color < that's where issue 2 is. After clicking with the pipette activated the color isn't selected. I can do this with "Dock to side of browser window" but sometimes this isn't ideal.

Issue 3:
- Still in Inspect Element > "Show in separate window".
- Click on Responsive Design Mode > nothing happens.

Like to see this resolved.
Not a security bug.
Group: firefox-core-security
Component: Untriaged → Developer Tools
I can only reproduce the issue #2 with FF55 (32b, Win 7) when the toolbox is undocked. In fact, the pipette is not able to pick a color to apply to the node. Screenshot: http://i.imgur.com/nOApAxX.jpg

Issue #3 is already fixed, it's bug 1346647.
Component: Developer Tools → Developer Tools: Inspector
Keywords: regression
Summary: Show in separate window issues → Eyedropper doesn't work to change the color of a node when toolbox is undocked
Attached file 1349483.html
I also reproduced issue 2 easily following the steps of comment 0. Let's flag this as a P2.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P2
Duplicate of this bug: 1429061
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Comment on attachment 8941159 [details]
Bug 1349483 - extract tooltip hidden callback from SwatchColorPickerTooltip;

https://reviewboard.mozilla.org/r/211424/#review217218
Attachment #8941159 - Flags: review?(pbrosset) → review+
Comment on attachment 8941160 [details]
Bug 1349483 - fix colorpicker eyedropper when devtools are in a window host;

https://reviewboard.mozilla.org/r/211426/#review217220
Attachment #8941160 - Flags: review?(pbrosset) → review+
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/252d8b06f90f
extract tooltip hidden callback from SwatchColorPickerTooltip;r=pbro
https://hg.mozilla.org/integration/autoland/rev/3575689ce191
fix colorpicker eyedropper when devtools are in a window host;r=pbro
https://hg.mozilla.org/mozilla-central/rev/252d8b06f90f
https://hg.mozilla.org/mozilla-central/rev/3575689ce191
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.