Tab Tray Menu label spacing in French is wrong

VERIFIED FIXED

Status

()

P1
normal
VERIFIED FIXED
2 years ago
a year ago

People

(Reporter: fluffyemily, Assigned: justindarc)

Tracking

unspecified
Other
iOS

Firefox Tracking Flags

(fxios8.0+, fxios-v8.0 verified, fxios-v9.0 verified)

Details

(Whiteboard: [MobileCore])

Attachments

(4 attachments)

(Reporter)

Description

2 years ago
Created attachment 8850004 [details]
IMG_0414.png

In the French localization, the Settings menu option wraps incorrectly. The spacing may need to be adjusted.
tracking-fxios: ? → 8.0+
Priority: -- → P2
This label is already shrunk down as much as possible. So we have two possibilities here:

- Use a different (shorter) word
- Include a hyphenation hint in Paramètres so that it is correctly broken.
Flags: needinfo?(lebedel.delphine)
Moving to Théo so he can decide what to do in this case. Thanks!
Flags: needinfo?(lebedel.delphine) → needinfo?(theo)
Paramètre<br>s is actually not the issue, it’s the 3-lines labels: “New private tab” and “Close all tabs”, some characters in the third line are cut-off.
For instance “onglets” reads “onqlets” since it is cut-off at the bottom (compare with the first “onglet” in “Nouvel onglet”)

Does that make more sense?
Flags: needinfo?(theo)
Thanks Théo. This is really weird .. if there is a line spacing issue then this may also be happening for other locales. I'll try to run screenshots for some more locales to see what is going on here.

This bug has been marked for inclusion in 8.0
(Assignee)

Updated

a year ago
Assignee: nobody → jdarcangelo
Status: NEW → ASSIGNED
(Assignee)

Comment 5

a year ago
Created attachment 8871932 [details] [review]
GitHub Pull Request

Just a heads up, this PR adds some patterns to .gitignore to prevent all the non-English imported locales from showing up as uncommitted changes in Git. I don't think this causes any problems, but you would probably know better than I :-)
Attachment #8871932 - Flags: review?(sleroux)
Created attachment 8872129 [details] [review]
Pull Request
Attachment #8872129 - Flags: review?(fpatel)
Iteration: --- → 1.23
Priority: P2 → P1
Created attachment 8872772 [details] [review]
Pull Request
Attachment #8872772 - Flags: review?(sleroux)
Attachment #8872129 - Flags: review?(fpatel)
Attachment #8872772 - Flags: review?(sleroux) → review+
Attachment #8871932 - Flags: review?(sleroux)
Verifying as fix on master 4538e6d3e and 8.0b3672. Tab Tray Menu is correctly displayed in French.
Status: RESOLVED → VERIFIED
status-fxios-v8.0: --- → verified
status-fxios-v9.0: --- → verified
You need to log in before you can comment on or make changes to this bug.