Closed
Bug 1349541
Opened 7 years ago
Closed 7 years ago
Tab Tray Menu label spacing in French is wrong
Categories
(Firefox for iOS :: Menu and Toolbar, defect, P1)
Tracking
()
VERIFIED
FIXED
Iteration:
1.23
People
(Reporter: fluffyemily, Assigned: justindarc)
Details
(Whiteboard: [MobileCore])
Attachments
(4 files)
In the French localization, the Settings menu option wraps incorrectly. The spacing may need to be adjusted.
Updated•7 years ago
|
Priority: -- → P2
Comment 1•7 years ago
|
||
This label is already shrunk down as much as possible. So we have two possibilities here: - Use a different (shorter) word - Include a hyphenation hint in Paramètres so that it is correctly broken.
Updated•7 years ago
|
Flags: needinfo?(lebedel.delphine)
Comment 2•7 years ago
|
||
Moving to Théo so he can decide what to do in this case. Thanks!
Flags: needinfo?(lebedel.delphine) → needinfo?(theo)
Comment 3•7 years ago
|
||
Paramètre<br>s is actually not the issue, it’s the 3-lines labels: “New private tab” and “Close all tabs”, some characters in the third line are cut-off. For instance “onglets” reads “onqlets” since it is cut-off at the bottom (compare with the first “onglet” in “Nouvel onglet”) Does that make more sense?
Flags: needinfo?(theo)
Comment 4•7 years ago
|
||
Thanks Théo. This is really weird .. if there is a line spacing issue then this may also be happening for other locales. I'll try to run screenshots for some more locales to see what is going on here. This bug has been marked for inclusion in 8.0
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → jdarcangelo
Status: NEW → ASSIGNED
Assignee | ||
Comment 5•7 years ago
|
||
Just a heads up, this PR adds some patterns to .gitignore to prevent all the non-English imported locales from showing up as uncommitted changes in Git. I don't think this causes any problems, but you would probably know better than I :-)
Attachment #8871932 -
Flags: review?(sleroux)
Comment 6•7 years ago
|
||
Attachment #8872129 -
Flags: review?(fpatel)
Updated•7 years ago
|
Iteration: --- → 1.23
Priority: P2 → P1
Comment 7•7 years ago
|
||
Attachment #8872772 -
Flags: review?(sleroux)
Updated•7 years ago
|
Attachment #8872129 -
Flags: review?(fpatel)
Updated•7 years ago
|
Attachment #8872772 -
Flags: review?(sleroux) → review+
Updated•7 years ago
|
Attachment #8871932 -
Flags: review?(sleroux)
Assignee | ||
Comment 8•7 years ago
|
||
Landed on master: https://github.com/mozilla-mobile/firefox-ios/commit/4c29abc404e94aa27c062b512633c67a2ebf796e Landed on v8.x: https://github.com/mozilla-mobile/firefox-ios/commit/799c673421c2496c44a62fb736d53d7e25c3bb3f
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Comment 9•7 years ago
|
||
Verifying as fix on master 4538e6d3e and 8.0b3672. Tab Tray Menu is correctly displayed in French.
You need to log in
before you can comment on or make changes to this bug.
Description
•