1349554 - 2.09 - 7.57% dromaeo_css / tcanvasmark (linux64, osx-10-10, windows7-32, windows8-64) regression on push f98a326bcf8d8095d2b6168eb2b3864d03f9dff2 (Mon Mar 20 2017)

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Ionuț Goldan [:igoldan]]

Talos has detected a Firefox performance regression from push f98a326bcf8d8095d2b6168eb2b3864d03f9dff2. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

  8%  dromaeo_css summary windows7-32 pgo      6634.55 -> 6132.3
  7%  dromaeo_css summary windows7-32 opt e10s 6103.95 -> 5692.09
  7%  dromaeo_css summary osx-10-10 opt e10s   7878.3 -> 7357.89
  6%  dromaeo_css summary windows8-64 opt e10s 6316.13 -> 5914.32
  6%  dromaeo_css summary osx-10-10 opt        7755.92 -> 7264.8
  6%  dromaeo_css summary windows7-32 opt      5942.55 -> 5578.47
  6%  dromaeo_css summary linux64 opt e10s     6685.84 -> 6278.19
  6%  dromaeo_css summary linux64 opt          6570.64 -> 6187.08
  6%  dromaeo_css summary windows8-64 opt      6192.18 -> 5846.37
  5%  dromaeo_css summary linux64 pgo e10s     7671.58 -> 7268.36
  4%  tcanvasmark summary linux64 pgo e10s     11551.25 -> 11112.71
  3%  tcanvasmark summary linux64 opt e10s     9268.08 -> 8999.38
  2%  tcanvasmark summary windows7-32 opt e10s 8716.04 -> 8502
  2%  tcanvasmark summary linux64 opt          8946.29 -> 8759.08

Improvements:

  3%  tart summary linux64 pgo e10s     5.27 -> 5.1
  3%  tart summary linux64 opt e10s     6.78 -> 6.61


You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=5542

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a treeherder page showing the Talos jobs in a pushlog format.

To learn more about the regressing test(s), please see: https://wiki.mozilla.org/Buildbot/Talos/Tests

For information on reproducing and debugging the regression, either on try or locally, see: https://wiki.mozilla.org/Buildbot/Talos/Running

*** Please let us know your plans within 3 business days, or the offending patch(es) will be backed out! ***

Our wiki page outlines the common responses and expectations: https://wiki.mozilla.org/Buildbot/Talos/RegressionBugsHandling

Comment 1

[Ionuț Goldan [:igoldan]]

:jdemooij I saw you later made a performance improvement, with bug 1348905.

A comparison view based on that can be seen here:
https://treeherder.mozilla.org/perf.html#/compare?originalProject=mozilla-inbound&originalRevision=f98a326bcf8d8095d2b6168eb2b3864d03f9dff2&newProject=mozilla-inbound&newRevision=7c9940c57e33c90326e8a450401d3babc9aa4c13&framework=1&filter=dromaeo

Comment 2

[Jan de Mooij [:jandem]]

Some regressions from this were expected.

I'd like to take a closer look at some of the Dromaeo tests though.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

these alerts seem to be fixed, is there more work to do here?

Comment 4

[Jan de Mooij [:jandem]]

(In reply to Joel Maher ( :jmaher) from comment #3)
> these alerts seem to be fixed, is there more work to do here?

Let's just close this then :)