134958 - Deleting a mailing list from the directory pane fails

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect, P2)

Description

[Ninoschka Baca]

Trunk build 2002-04-01: WinMe

Overview: Deleting an address book when it is selected in the directory pane 
fails. After an exit/restart, it is still present.

Steps to reproduce:
1. Create a mailing list
2. Select the list in the directory pane
3. Select the Delete button and it states "Are you sure you want to delete the 
selected mailing list?", OK.

Actual Results: The list still displays in the directory pane and the results 
pane. Close/reopen AB, the lists are still present. Exit/restart, the lists are 
still present. 
Workaround: I have to select the list from the results pane, then the Delete 
works.

Expected Results: The list should be removed from the directory pane and the 
results pane immediately.

Comment 1

[Ninoschka Baca]

Marking nsbeta1 because this used to work and the user will expect the ability 
to delete a list from the directory pane.

Comment 2

[(not reading, please use [e-mail] instead)]

*** Bug 138093 has been marked as a duplicate of this bug. ***

Comment 3

[(not reading, please use [e-mail] instead)]

taking.

Comment 4

[(not reading, please use [e-mail] instead)]

accepting.

Comment 5

[(not reading, please use [e-mail] instead)]

ok, I see the problem.

we're somehow using the wrong parent when we try to delete.

so instead of using my PAB as the parent when deleting a mailing list from my 
PAB, I'm using my LDAP addressbook.

working on it...

Comment 6

[(not reading, please use [e-mail] instead)]

ok, the problem is GetParentRow() in abCommon.js doesn't work right.

working on it.  good news is that this is the only code (mailing list delete) 
that uses it.

Comment 7

[(not reading, please use [e-mail] instead)]

Attachment: patch

Comment 8

[David :Bienvenu]

Comment on attachment 79849 [details] [diff] [review]
patch

sr=bienvenu

Comment 9

[(not reading, please use [e-mail] instead)]

> good news is that this is the only code (mailing list delete)

sorry, that should read:  "good news is that this is the only code (deleting 
from the dir tree) that uses it."

this code doesn't get executed when you attempt to delete the CAB or the PAB, 
but any other directories (local, ldap or mailing lists) will execute it.

Comment 10

[Joe Hewitt (gone)]

Comment on attachment 79849 [details] [diff] [review]
patch

r=hewitt

Comment 11

[(not reading, please use [e-mail] instead)]

fixed on trunk.

Comment 12

[scottputterman]

Without this patch, can you still delete a mailing list from the results pane?

Comment 13

[(not reading, please use [e-mail] instead)]

> Without this patch, can you still delete a mailing list from the results pane?

yes.

Comment 14

[scottputterman]

marking adt1.0.0-.  There's currently a workaround for this.  Let's make sure
this gets into the next release.

Comment 15

[(not reading, please use [e-mail] instead)]

*** Bug 139336 has been marked as a duplicate of this bug. ***

Comment 16

[(not reading, please use [e-mail] instead)]

putterman marked the dup adt2, so changing this from adt3 to adt2.

removing adt1.0.0- so it can be re-evaluated for the branch, if we plan on 
using that for the next mozilla release / ns beta.

I'm really confused: branch / trunk & mozilla 1.0, 1.0.1 / ns beta, etc, etc.

Comment 17

[(not reading, please use [e-mail] instead)]

putterman says:  adt1.0.0-, won't make it for beta, but will for ns rtm.

Comment 18

[scottputterman]

adding rtm.

Comment 19

[Ninoschka Baca]

Trunk build 2002-05-22: WinMe, Linux RH 7.1, Mac 10.1.3 
Verified Fixed on the trunk. 

I will check the branch once this bug is marked fixed1.0.0.

Comment 20

[Jaime Rodriguez, Jr.]

adt1.0.1+ (on ADT's behalf) for checkin to the 1.0 branch, pending Driver's
approval.

Comment 21

[(not reading, please use [e-mail] instead)]

seting TM to 1.0.1

Comment 22

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 79849 [details] [diff] [review]
patch

please check into the 1.0.1 branch ASAP. once landed remove the 
mozilla1.0.1+ keyword and add the fixed1.0.1 keyword

Comment 23

[(not reading, please use [e-mail] instead)]

fixed on trunk and branch.

Comment 24

[Ninoschka Baca]

Branch build 2002-06-11: WinMe
verified1.0.1