1349606 - Assertion failure: !(mHintsHandledByAncestors & nsChangeHint_ReconstructFrame) (why restyle descendants if we are reconstructing the frame for an ancestor?), at GeckoRestyleManager.cpp:1169

Status: RESOLVED DUPLICATE of bug 1357869

(Core :: Layout, defect)

Description

[Carsten Book [:Tomcat]]

Attachment: bughunter stack

found by bughunter topsites run on latest quantum builds from taskcluster
on  http://www.optymalizacja.com

Steps to reproduce:
-> Load http://www.optymalizacja.com
--> Assertion failure

Investigating if this is just quantum or also stylo or even normal builds.


Assertion failure: !(mHintsHandledByAncestors & nsChangeHint_ReconstructFrame) (why restyle descendants if we are reconstructing the frame for an ancestor?), at /home/worker/workspace/build/src/layout/base/GeckoRestyleManager.cpp:1169
#01: mozilla::ElementRestyler::RestyleSelf [layout/base/GeckoRestyleManager.cpp:2453]
#02: mozilla::ElementRestyler::Restyle [layout/base/GeckoRestyleManager.cpp:1834]
#03: mozilla::ElementRestyler::RestyleContentChildren [layout/base/GeckoRestyleManager.cpp:3445]
#04: mozilla::ElementRestyler::RestyleChildren [layout/base/GeckoRestyleManager.cpp:2963]
#05: mozilla::ElementRestyler::Restyle [layout/base/GeckoRestyleManager.cpp:1989]
#06: mozilla::ElementRestyler::RestyleContentChildren [layout/base/GeckoRestyleManager.cpp:3445]
#07: mozilla::ElementRestyler::RestyleChildren [layout/base/GeckoRestyleManager.cpp:2963]
#08: mozilla::ElementRestyler::Restyle [layout/base/GeckoRestyleManager.cpp:1989]
#09: mozilla::ElementRestyler::RestyleContentChildren [layout/base/GeckoRestyleManager.cpp:3445]
#10: mozilla::ElementRestyler::RestyleChildren [layout/base/GeckoRestyleManager.cpp:2963]
#11: mozilla::ElementRestyler::Restyle [layout/base/GeckoRestyleManager.cpp:1989]
#12: mozilla::ElementRestyler::RestyleContentChildren [layout/base/GeckoRestyleManager.cpp:3445]
#13: mozilla::ElementRestyler::RestyleChildren [layout/base/GeckoRestyleManager.cpp:2963]
#14: mozilla::ElementRestyler::Restyle [layout/base/GeckoRestyleManager.cpp:1989]
#15: mozilla::ElementRestyler::RestyleContentChildren [layout/base/GeckoRestyleManager.cpp:3445]
#16: mozilla::ElementRestyler::RestyleChildren [layout/base/GeckoRestyleManager.cpp:2963]
#17: mozilla::ElementRestyler::Restyle [layout/base/GeckoRestyleManager.cpp:1989]
#18: mozilla::ElementRestyler::RestyleContentChildren [layout/base/GeckoRestyleManager.cpp:3445]
#19: mozilla::ElementRestyler::RestyleChildren [layout/base/GeckoRestyleManager.cpp:2963]
#20: mozilla::ElementRestyler::Restyle [layout/base/GeckoRestyleManager.cpp:1989]
#21: mozilla::ElementRestyler::RestyleContentChildren [layout/base/GeckoRestyleManager.cpp:3445]
#22: mozilla::ElementRestyler::RestyleChildren [layout/base/GeckoRestyleManager.cpp:2963]
#23: mozilla::ElementRestyler::Restyle [layout/base/GeckoRestyleManager.cpp:1989]
#24: mozilla::ElementRestyler::RestyleContentChildren [layout/base/GeckoRestyleManager.cpp:3445]
#25: mozilla::ElementRestyler::RestyleChildren [layout/base/GeckoRestyleManager.cpp:2963]
#26: mozilla::ElementRestyler::Restyle [layout/base/GeckoRestyleManager.cpp:1989]
#27: mozilla::ElementRestyler::RestyleContentChildren [layout/base/GeckoRestyleManager.cpp:3445]
#28: mozilla::ElementRestyler::RestyleChildren [layout/base/GeckoRestyleManager.cpp:2963]
#29: mozilla::ElementRestyler::Restyle [layout/base/GeckoRestyleManager.cpp:1989]
#30: mozilla::ElementRestyler::ComputeStyleChangeFor [layout/base/GeckoRestyleManager.cpp:3111]

Comment 1

[Carsten Book [:Tomcat]]

Cameron, could this be realted to bug 1302054 or the other recent changes for GeckoRestyleManager.cpp ?

Comment 2

[Bobby Holley (:bholley)]

This stack looks like non-Stylo, FWIW. So probably higher priority.

Comment 3

[Cameron McCormack (:heycam)]

Yes, sounds like the bug 1301258 changes.  I'll take a look.

Comment 4

[Carsten Book [:Tomcat]]

(In reply to Bobby Holley (:bholley) (busy with Stylo) from comment #2)
> This stack looks like non-Stylo, FWIW. So probably higher priority.

indeed , bughunter reports the same assertion also now for general trunk debug builds on windows. So its a general issue.

Comment 5

[Carsten Book [:Tomcat]]

seems http://forums.x-plane.org/index.php?/forums/topic/115716-input-not-supported/ is also a url where this assertion can be reproduced.

Comment 6

[Cameron McCormack (:heycam)]

I can't reproduce this on Linux with either a stylo or non-stylo build, on either of those URLs.

Comment 7

[Carsten Book [:Tomcat]]

(In reply to Cameron McCormack (:heycam) from comment #6)
> I can't reproduce this on Linux with either a stylo or non-stylo build, on
> either of those URLs.

just tried on windows trunk debug build - Built from https://hg.mozilla.org/mozilla-central/rev/01d1dedf400d4be413b1a0d48090dca7acf29637

and crashed on the url from comment #0 on load with Assertion failure: !(mHintsHandledByAncestors & nsChangeHint_ReconstructFrame) (why restyle descendants if we are reconstructing the frame for an ancestor?), at c:/builds/moz2_slave/m-cen-w32-d-000000000000000000/build/src/layout/base/GeckoRestyleManager.cpp:1169

Comment 8

[Cameron McCormack (:heycam)]

(In reply to Carsten Book [:Tomcat] from comment #7)
> just tried on windows trunk debug build - Built from
> https://hg.mozilla.org/mozilla-central/rev/
> 01d1dedf400d4be413b1a0d48090dca7acf29637

Was just with a build from treeherder, or a local build you built yourself?  I just tried a local Windows debug build of current mozilla-central tip, and grabbing the latest WinXP debug build from treeherder, and still couldn't reproduce using these two URLs. :(

Comment 9

[Bob Clary [:bc] (inactive)]

I resubmitted http://www.optymalizacja.com/ to bughunter and reproduced on Fedora, Ubuntu, Windows 7 and Windows 10 using taskcluster debug builds though not 100% of the time. I tested here locally on Fedora and was able to reproduce though I had to attempt it several times leading me to believe this is either intermittent or ad dependent.

Comment 11

[Bob Clary [:bc] (inactive)]

This bug wasn't a dupe since it is still reproducible. It is being worked on in bug 1360970 now.