Closed Bug 1349611 Opened 4 years ago Closed 4 years ago

Update Clang hash in releng.manifest


(Firefox Build System :: General, enhancement)

Not set


(firefox55 fixed)

Tracking Status
firefox55 --- fixed


(Reporter: decoder, Assigned: decoder)



(Keywords: sec-want, Whiteboard: [adv-main55-])


(1 file)

Since :dholbert and :froydnj figured out in bug 1349268 that our current Clang 3.9 (only used by releng.manifest) misses a patch that it should have, we need to update the Clang hash in linux64/releng.manifest to use the fixed Clang. 

Furthermore, I would like to use that version of Clang also in asan.manifest so we have Clang 3.9 for our Linux ASan builds.

The hash of the broken Clang doesn't seem to be anywhere else in the codebase since all other builds are still using Clang 3.8 apparently (we should change that at some point, Clang 3.8 is quite old).

Will attach the patch as soon as the final try run is through.
Blocks: 1267650
Comment on attachment 8850157 [details]
Bug 1349611 - Fix broken Clang hash in releng.manifest.
Attachment #8850157 - Flags: review?(nfroyd) → review+
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 24044e092d29 -d 08b46c736a62: rebasing 383362:24044e092d29 "Bug 1349611 - Fix broken Clang hash and upgrade ASan Clang to 3.9. r=froydnj" (tip)
merging browser/config/tooltool-manifests/linux64/asan.manifest
merging browser/config/tooltool-manifests/linux64/releng.manifest
warning: conflicts while merging browser/config/tooltool-manifests/linux64/asan.manifest! (edit, then use 'hg resolve --mark')
warning: conflicts while merging browser/config/tooltool-manifests/linux64/releng.manifest! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
No longer blocks: 1267650
Meanwhile, Clang for ASan was already upgraded to 3.9 in bug 1346442. I'm going to change this bug then to only update releng.manifest instead.
Summary: Update Clang hash in releng.manifest and asan.manifest (to upgrade ASan to Clang 3.9) → Update Clang hash in releng.manifest
Pushed by
Fix broken Clang hash in releng.manifest. r=froydnj
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Whiteboard: [adv-main55-]
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.