Closed
Bug 1349611
Opened 8 years ago
Closed 8 years ago
Update Clang hash in releng.manifest
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox55 fixed)
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: decoder, Assigned: decoder)
References
Details
(Keywords: sec-want, Whiteboard: [adv-main55-])
Attachments
(1 file)
Since :dholbert and :froydnj figured out in bug 1349268 that our current Clang 3.9 (only used by releng.manifest) misses a patch that it should have, we need to update the Clang hash in linux64/releng.manifest to use the fixed Clang.
Furthermore, I would like to use that version of Clang also in asan.manifest so we have Clang 3.9 for our Linux ASan builds.
The hash of the broken Clang doesn't seem to be anywhere else in the codebase since all other builds are still using Clang 3.8 apparently (we should change that at some point, Clang 3.8 is quite old).
Will attach the patch as soon as the final try run is through.
Comment hidden (mozreview-request) |
Comment 2•8 years ago
|
||
mozreview-review |
Comment on attachment 8850157 [details]
Bug 1349611 - Fix broken Clang hash in releng.manifest.
https://reviewboard.mozilla.org/r/122846/#review125066
Attachment #8850157 -
Flags: review?(nfroyd) → review+
Comment 3•8 years ago
|
||
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.
hg error in cmd: hg rebase -s 24044e092d29 -d 08b46c736a62: rebasing 383362:24044e092d29 "Bug 1349611 - Fix broken Clang hash and upgrade ASan Clang to 3.9. r=froydnj" (tip)
merging browser/config/tooltool-manifests/linux64/asan.manifest
merging browser/config/tooltool-manifests/linux64/releng.manifest
warning: conflicts while merging browser/config/tooltool-manifests/linux64/asan.manifest! (edit, then use 'hg resolve --mark')
warning: conflicts while merging browser/config/tooltool-manifests/linux64/releng.manifest! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Assignee | ||
Comment 4•8 years ago
|
||
Meanwhile, Clang for ASan was already upgraded to 3.9 in bug 1346442. I'm going to change this bug then to only update releng.manifest instead.
Summary: Update Clang hash in releng.manifest and asan.manifest (to upgrade ASan to Clang 3.9) → Update Clang hash in releng.manifest
Comment hidden (mozreview-request) |
Pushed by choller@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f48e43c2ac77
Fix broken Clang hash in releng.manifest. r=froydnj
Comment 7•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Updated•7 years ago
|
Whiteboard: [adv-main55-]
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•