Closed Bug 1349630 Opened 3 years ago Closed 3 years ago

Optimize PlacesSyncUtils.bookmarks.havePendingChanges

Categories

(Firefox :: Sync, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
Firefox 55
Tracking Status
firefox55 --- fixed

People

(Reporter: tcsc, Assigned: lina)

Details

Attachments

(1 file)

See bug 1345754 (esp. comment 3). At the moment this is fairly naive since we find and collect all changes. We only care if any exist.
I did this in the first cut of bug 1335891, so I'll snag this, if that's OK.
Assignee: nobody → kit
Status: NEW → ASSIGNED
Comment on attachment 8850137 [details]
Bug 1349630 - Optimize `PlacesSyncUtils.bookmarks.havePendingChanges`.

https://reviewboard.mozilla.org/r/122828/#review125116

Assuming there's no way to throw a LIMIT 1 or something in there to make the database give up after it sees a single item, this seems fine to me.
Attachment #8850137 - Flags: review?(tchiovoloni) → review+
Pushed by kcambridge@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7c7f3615f433
Optimize `PlacesSyncUtils.bookmarks.havePendingChanges`. r=tcsc
I realized we don't need the count at all; `SELECT EXISTS` should do the trick.
https://hg.mozilla.org/mozilla-central/rev/7c7f3615f433
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in before you can comment on or make changes to this bug.