Building TB53.0b1 failed sanity check -- WARNING : ac_add_options --enable-profiling not in macosx64

RESOLVED FIXED

Status

defect
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: wsmwk, Assigned: Fallen)

Tracking

52 Branch

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
+++ This bug was initially created as a clone of Bug #1348075 +++


2017-03-22 07:49:00,861 : INFO : Comparing thunderbird mozconfigs to nightly mozconfigs...
2017-03-22 07:49:00,992 : WARNING : ac_add_options --enable-profiling not in macosx64 ['ac_add_options --enable-update-channel=nightly', 'mk_add_options CLIENT_PY_ARGS="--hg-options=\'--verbose --time\' --hgtool=../tools/buildfarm/utils/hgtool.py --skip-chatzilla --skip-comm --skip-inspector --skip-venkman --tinderbox-print"', 'ac_add_options --enable-codesighs', 'mk_add_options MOZ_MAKE_FLAGS="-j4"', 'ac_add_options --enable-signmar', 'ac_add_options --enable-js-diagnostics', 'ac_add_options --with-branding=browser/branding/nightly', 'if test "${MOZ_UPDATE_CHANNEL}" = "nightly"; then', 'ac_add_options --with-macbundlename-prefix=Firefox', 'fi', 'mk_add_options MOZ_MAKE_FLAGS="-j12"', 'ac_add_options --with-ccache', 'ac_add_options --disable-install-strip', 'ac_add_options --enable-instruments', 'ac_add_options --enable-dtrace']!
2017-03-22 07:49:00,993 : ERROR : found in mail/config/mozconfigs/macosx64/nightly but not in mail/config/mozconfigs/macosx64/release: ac_add_options --enable-profiling
2017-03-22 07:49:01,710 : ERROR : Error verifying mozconfigs

Comment 1

2 years ago
Remove --enable-profiling from mail/config/mozconfigs/macosx64/nightly?
Perhaps you could pre-r+ such a one-liner ;-)
Flags: needinfo?(philipp)

Comment 2

2 years ago
Hmm, maybe not, that switch is widely used:
https://dxr.mozilla.org/comm-central/search?q=enable-profiling&redirect=false
but never in release files. So perhaps we should remove the check instead.
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Flags: needinfo?(philipp)
Posted patch Fix - v1 β€” β€” Splinter Review
I've tested this with a custom python script that runs verify_mozconfigs with the right arguments. It works fine for all platforms now.
Attachment #8850148 - Flags: review?(rail)

Updated

2 years ago
Attachment #8850148 - Flags: review?(rail) → review+
Thanks for the quick review!

https://hg.mozilla.org/build/tools/rev/6e45923eabfdb2cf9c76d9f5c797f3ed38bbb62f
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.