Closed
Bug 1349631
Opened 7 years ago
Closed 7 years ago
Building TB53.0b1 failed sanity check -- WARNING : ac_add_options --enable-profiling not in macosx64
Categories
(Thunderbird :: Build Config, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: wsmwk, Assigned: Fallen)
Details
Attachments
(1 file)
1.36 KB,
patch
|
rail
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1348075 +++ 2017-03-22 07:49:00,861 : INFO : Comparing thunderbird mozconfigs to nightly mozconfigs... 2017-03-22 07:49:00,992 : WARNING : ac_add_options --enable-profiling not in macosx64 ['ac_add_options --enable-update-channel=nightly', 'mk_add_options CLIENT_PY_ARGS="--hg-options=\'--verbose --time\' --hgtool=../tools/buildfarm/utils/hgtool.py --skip-chatzilla --skip-comm --skip-inspector --skip-venkman --tinderbox-print"', 'ac_add_options --enable-codesighs', 'mk_add_options MOZ_MAKE_FLAGS="-j4"', 'ac_add_options --enable-signmar', 'ac_add_options --enable-js-diagnostics', 'ac_add_options --with-branding=browser/branding/nightly', 'if test "${MOZ_UPDATE_CHANNEL}" = "nightly"; then', 'ac_add_options --with-macbundlename-prefix=Firefox', 'fi', 'mk_add_options MOZ_MAKE_FLAGS="-j12"', 'ac_add_options --with-ccache', 'ac_add_options --disable-install-strip', 'ac_add_options --enable-instruments', 'ac_add_options --enable-dtrace']! 2017-03-22 07:49:00,993 : ERROR : found in mail/config/mozconfigs/macosx64/nightly but not in mail/config/mozconfigs/macosx64/release: ac_add_options --enable-profiling 2017-03-22 07:49:01,710 : ERROR : Error verifying mozconfigs
Comment 1•7 years ago
|
||
Remove --enable-profiling from mail/config/mozconfigs/macosx64/nightly? Perhaps you could pre-r+ such a one-liner ;-)
Flags: needinfo?(philipp)
Comment 2•7 years ago
|
||
Hmm, maybe not, that switch is widely used: https://dxr.mozilla.org/comm-central/search?q=enable-profiling&redirect=false but never in release files. So perhaps we should remove the check instead.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Flags: needinfo?(philipp)
Assignee | ||
Comment 3•7 years ago
|
||
I've tested this with a custom python script that runs verify_mozconfigs with the right arguments. It works fine for all platforms now.
Attachment #8850148 -
Flags: review?(rail)
Updated•7 years ago
|
Attachment #8850148 -
Flags: review?(rail) → review+
Assignee | ||
Comment 4•7 years ago
|
||
Thanks for the quick review! https://hg.mozilla.org/build/tools/rev/6e45923eabfdb2cf9c76d9f5c797f3ed38bbb62f
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•