1349643 - Turning on webrender profiler pref crashes browser

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

Attachment: Backtrace

There's a "this is on the compositor thread" assertion in wr_api_send_external_event, but it's getting called on the main thread. See attached backtrace.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1349643 - Loosen thread assertion slightly.

When changing the webrender profiler enabled/disabled state, the change propagates
to webrender via the main thread. This violates a thread assertion. However,
the thread assertion is mostly for documentation, so we can loosen it a little
to allow for this scenario.

Review commit: https://reviewboard.mozilla.org/r/122836/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/122836/

Comment 2

[Nicolas Silva [:nical]]

Comment on attachment 8850147 [details]
Bug 1349643 - Loosen thread assertion slightly.

https://reviewboard.mozilla.org/r/122836/#review125822

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/8daa3df15945
Loosen thread assertion slightly. r=nical

Comment 4

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/mozilla-central/rev/8daa3df15945