Closed Bug 134967 Opened 22 years ago Closed 21 years ago

building security with gmake on windows doesn't handle spaces in $USERNAME

Categories

(NSS :: Build, defect, P1)

Product:
NSS
Platform:
x86
Windows 2000
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: tvl, Assigned: wtc)

References

Details

Attachments

(1 file)

Proposed patch
758 bytes, patch
netscape
: review+
Details | Diff | Splinter Review 
mozilla/security/coreconf/WIN32.mak uses $USERNAME for a debug cpp symbol, but
the build fails in that value has a space in it.  this can be a major pain if
your companies network login has a space.  you end up having to log out from the
network, use a local id to build, etc.  and in most corp environments that means
you don't have access to all sorts of things (printers, etc.).  either the
makefiles should support the spaces in the names, or it should try to define the
debug symbol.
NSS.
Assignee: seawood → wtc
Component: Build Config → Build
Product: Browser → NSS
QA Contact: granrose → wtc
Version: other → 3.0
Target NSS 3.5, priority P2.
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Priority: -- → P2
Target Milestone: --- → 3.5
This fell through the cracks.  Sorry.  We've already
fixed this in the other components of Mozilla.  I will
apply the fix to NSS.
Priority: P2 → P1
Target Milestone: 3.5 → 3.7
A workaround is to set USERNAME to something else on the command line before
building, but its still a major pain.

Moved to target milestone 3.8 because the original
NSS 3.7 release has been renamed 3.8.
Target Milestone: 3.7 → 3.8
*** Bug 186164 has been marked as a duplicate of this bug. ***
Attached patch Proposed patch — — Splinter Review 

    
  

        Attachment #114527 -
        Flags: review?(seawood)

        Attachment #114527 -
        Flags: review?(seawood) → review+

    
    

    
  
Patch checked into NSS TIP (NSS 3.8).
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: