1349690 - Improve dangling-exception logging in AutoJSAPI::InitInternal to deal better with exceptions from a different origin

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Boris Zbarsky [:bzbarsky]]

Right now if "exnObj" is a security wrapper we will have a useless assertion.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Improve dangling-exception logging in AutoJSAPI::InitInternal to deal better with exceptions from a different origin

MozReview-Commit-ID: IpvRcBC2d6k

Comment 2

[Bobby Holley (:bholley)]

Comment on attachment 8850159 [details] [diff] [review]
Improve dangling-exception logging in AutoJSAPI::InitInternal to deal better with exceptions from a different origin

Review of attachment 8850159 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/ScriptSettings.cpp
@@ +375,5 @@
>      JS_ClearPendingException(aCx);
>      if (exn.isObject()) {
>        JS::Rooted<JSObject*> exnObj(aCx, &exn.toObject());
>  
> +      // Make sure we can actually read things from it.

Make a note here that this is only safe because it's being used in debug-only printf code. Otherwise we'd risk potentially leaking sensitive string information.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3ccb231829a9
Improve dangling-exception logging in AutoJSAPI::InitInternal to deal better with exceptions from a different origin.  r=bholley

Comment 4

[Carsten Book [:Tomcat]]

backed this out in https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=1e0598886d349e919fbe71ab3534574e13d40468&filter-classifiedState=unclassified&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception because of bustage https://treeherder.mozilla.org/logviewer.html#?job_id=85840526&repo=mozilla-inbound

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/85658d613c77
Backed out changeset 3ccb231829a9

Comment 6

[Boris Zbarsky [:bzbarsky]]

Gah.  I must have built this opt-only.  :(

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d8d6b8f76ca5
Improve dangling-exception logging in AutoJSAPI::InitInternal to deal better with exceptions from a different origin.  r=bholley

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d8d6b8f76ca5