Closed Bug 1349690 Opened 4 years ago Closed 4 years ago

Improve dangling-exception logging in AutoJSAPI::InitInternal to deal better with exceptions from a different origin

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(1 file)

Right now if "exnObj" is a security wrapper we will have a useless assertion.
Blocks: 1349542
Comment on attachment 8850159 [details] [diff] [review]
Improve dangling-exception logging in AutoJSAPI::InitInternal to deal better with exceptions from a different origin

Review of attachment 8850159 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/ScriptSettings.cpp
@@ +375,5 @@
>      JS_ClearPendingException(aCx);
>      if (exn.isObject()) {
>        JS::Rooted<JSObject*> exnObj(aCx, &exn.toObject());
>  
> +      // Make sure we can actually read things from it.

Make a note here that this is only safe because it's being used in debug-only printf code. Otherwise we'd risk potentially leaking sensitive string information.
Attachment #8850159 - Flags: review?(bobbyholley) → review+
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3ccb231829a9
Improve dangling-exception logging in AutoJSAPI::InitInternal to deal better with exceptions from a different origin.  r=bholley
Gah.  I must have built this opt-only.  :(
Flags: needinfo?(bzbarsky)
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d8d6b8f76ca5
Improve dangling-exception logging in AutoJSAPI::InitInternal to deal better with exceptions from a different origin.  r=bholley
https://hg.mozilla.org/mozilla-central/rev/d8d6b8f76ca5
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.