1349700 - complain if C++ headers not in config/stl-headers are included

Status: NEW

(Developer Infrastructure :: Source Code Analysis, enhancement, P3)

Description

[Nathan Froyd [:froydnj]]

It's not safe to include standard C++ headers that throw exceptions unless they've been wrapped via config/stl-headers.  We should check for such inclusions and complain--but note that we only need to complain on platforms where we WRAP_STL_INCLUDES.

Inspired by discussions in bug 1347679.

Comment 1

[Xidorn Quan [:xidorn] UTC+11]

We should complain the same thing for every platform we build to help people knowing bustage in their code as soon as possible. (I've been feeling sad lots of times when I got all non-Windows build busted because of lack of some warning in MSVC.)

Comment 2

[Nika Layzell [:nika] (ni? for response)]

(In reply to Xidorn Quan [:xidorn] (UTC+10) from comment #1)
> We should complain the same thing for every platform we build to help people
> knowing bustage in their code as soon as possible. (I've been feeling sad
> lots of times when I got all non-Windows build busted because of lack of
> some warning in MSVC.)

I agree, but I also should note that this analysis would, for the most part, be run on infrastructure (as part of the static-analysis builds). We're working on making static analysis easier to run locally in bug 1328454 which might make this nicer.