1349716 - Pressing Enter on "Switch to tab" suggestion for a full url match loads it in the current tab.

Status: RESOLVED WORKSFORME

(Firefox :: Address Bar, defect, P2)

Description

[684sigma]

I have a problem with Firefox Beta 52. It also happens in Beta 53, Nightly 55. Doesn't happen in ESR 45.
Sometimes when I select "Switch to tab" suggestion in location bar and press enter, it loads url in current tab.
Here's how to reproduce it

1. Copy url "https://bugzilla.mozilla.org/show_bug.cgi?id=1344509", open new tab, navigate to that url.
2. Open new tab, paste the url into location bar.
3. Press Down arrow to select suggestion "Switch to tab", press Enter.

Result: url loads in current tab.
Expected: browser should switch to existing tab, as suggestion says.

Comment 1

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=3fe5546bc877aa00eeb88dcf4adb38e12f82f14d&tochange=c35d8f056f6745e084a383ad3896afb8fd2facaa

Regressed by:
c35d8f056f67	Marco Bonardo — Bug 1292310 - Enter may wrongly confirm a mouse selected entry in the urlbar. r=adw

Comment 2

[Liz Henry (:lizzard) (relman/hg->git project)]

Too late for a fix for 53, fix-optional for 54, minor carryover regression.

Comment 3

[Marco Bonardo [:mak]]

IS this still reproducible with recent key/mouse rework?

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

I just tried the steps from comment 0 and I don't see this any more. Probably fixed by bug 1295458.

Comment 5

[Kestrel]

Someone on reddit noticed this recently: 

https://new.reddit.com/r/firefox/comments/9xb80q/awesome_bar_navigate_to_tab_drop_down_list/

"Switch to Tab" works with partial URL matches and also full URL matches when clicked with the mouse but when using the keyboard a full match will load in the current tab instead of switching.

Comment 6

[Drew Willcoxon :adw]

Thanks Kestrel, I see that too.  Did some debugging -- when handleCommand is called due to a click, this.value is correctly a switchtab action URL.  But when it's called due to an enter keypress, this.value is the plain URL of the switch-to-tab tab.  It may have something to do with our deferred enter keypress handling, but I don't immediately see how.

Comment 7

[Drew Willcoxon :adw]

... or the nsAutoCompleteController.cpp changes in https://hg.mozilla.org/mozilla-central/rev/c35d8f056f67 which Alice narrowed down in comment 1.

Comment 8

[Marco Bonardo [:mak]]

let's move the handling to bug 1507755 that is newer, this was reported as fixed in comment 4 and there may have been a new regression in the meanwhile.