remove support for standalone about:addons UI

RESOLVED FIXED in Firefox 55

Status

()

Toolkit
Add-ons Manager
P3
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: rhelmer, Assigned: rhelmer)

Tracking

unspecified
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: triaged)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

a year ago
about:addons can be run either in a tab, or in a standalone window.

We run tests for both of these states and it's a burden to maintain. Firefox does not use this, I am not sure about other apps but I don't think there's a reason they could not run in a tabbed browser window instead.

Let's remove tests and any supporting code for the standalone window UI.
See Also: → bug 1350992

Updated

a year ago
Priority: -- → P3
Whiteboard: triaged
(Assignee)

Updated

a year ago
Blocks: 1355998
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Please don't forget to remove strings if they're not used anywhere else.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Comment 9

a year ago
(In reply to Francesco Lodolo [:flod] from comment #6)
> Please don't forget to remove strings if they're not used anywhere else.

Thanks! Looks like there are a few for the tooltips on the back/forward buttons - I'll make sure those aren't used elsewhere and remove them if not.
(Assignee)

Comment 10

a year ago
It's actually turning out to be a little more complex than I'd hoped to remove everything. I am hitting some test failures that are difficult to debug due to the callback depth (12 levels deep in some places!) so I am going to land the basic test removal now to unblock the Screenshots bug 1355998 and do the larger code+strings+remaining tests after.
Keywords: leave-open
(Assignee)

Updated

a year ago
Attachment #8866644 - Attachment is obsolete: true
Attachment #8866644 - Flags: review?(aswan)

Comment 11

a year ago
mozreview-review
Comment on attachment 8866594 [details]
Bug 1349723 - remove tests for about:addons UI in standalone window.

https://reviewboard.mozilla.org/r/138198/#review141854

::: toolkit/mozapps/extensions/test/browser/browser_bug562797.js:225
(Diff revision 4)
>      });
>    });
>  });
>  
>  // Tests that browsing to the add-ons manager from a website and going back works
>  // Only relevant for in-content UI

this line could go

::: toolkit/mozapps/extensions/test/browser/browser_bug562797.js:400
(Diff revision 4)
>    });
>  });
>  
>  // Tests than navigating to a website and then going back returns to the
>  // previous view
>  // Only relevant for in-content UI

ditto

::: toolkit/mozapps/extensions/test/browser/browser_bug562797.js:526
(Diff revision 4)
>    });
>  });
>  
>  // Tests that going back from a webpage to a detail view loaded from a search
>  // result works
>  // Only relevant for in-content UI

and again, several more below

::: toolkit/mozapps/extensions/test/browser/browser_types.js
(Diff revision 4)
> -    is(gBrowser.canGoBack, canGoBack, "canGoBack should be correct");
> -    is(gBrowser.canGoForward, canGoForward, "canGoForward should be correct");

why is this getting removed?
Attachment #8866594 - Flags: review?(aswan) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Comment 16

a year ago
So. It turns out that `is_hidden` in head.js happens to force a layout flush, which is necessary for one of the later tests which looks at the DOM and tries to pick out the right addon by the element value.

Since we've removed the call to `is_hidden` I've made the layout flush explicit which gets this test passing.
Comment hidden (mozreview-request)

Comment 18

a year ago
Pushed by rhelmer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4e0fd4da6d4d
remove tests for about:addons UI in standalone window. r=aswan
(Assignee)

Updated

a year ago
Keywords: leave-open
(Assignee)

Updated

a year ago
Blocks: 1364333

Comment 19

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/4e0fd4da6d4d
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.