Intermittent browser/base/content/test/tabs/browser_tabCloseProbes.js | Should only be 1 collected value. - 0 == 1 - JS frame :: chrome://mochitests/content/browser/browser/base/content/test/tabs/browser_tabCloseProbes.js :: assertCount :: line 23

RESOLVED FIXED in Firefox 55

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: intermittent-bug-filer, Assigned: mconley)

Tracking

({intermittent-failure})

unspecified
Firefox 55
intermittent-failure
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [stockwell fixed])

Attachments

(1 attachment)

This test landed as part of bug 1340842.
Blocks: 1340842
Component: General → Tabbed Browser
Flags: needinfo?(mconley)
Comment hidden (Intermittent Failures Robot)
Whiteboard: [stockwell needswork]
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
See Also: → bug 1353061
See Also: bug 1353061
Duplicate of this bug: 1353061
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Mike, can you take a look at this, thanks!
Comment hidden (Intermittent Failures Robot)
(Assignee)

Comment 13

2 years ago
Finally reached this point in my queue! Will look at this tomorrow.
Comment hidden (mozreview-request)
(Assignee)

Updated

2 years ago
Flags: needinfo?(mconley)

Comment 15

2 years ago
mozreview-review
Comment on attachment 8855808 [details]
Bug 1349787 - Make sure browser_tabCloseProbes.js waits for tabs to be fully open before closing them.

https://reviewboard.mozilla.org/r/127700/#review130482
Attachment #8855808 - Flags: review?(dtownsend) → review+

Comment 16

2 years ago
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/389893c52830
Make sure browser_tabCloseProbes.js waits for tabs to be fully open before closing them. r=mossop
Comment hidden (Intermittent Failures Robot)
Comment hidden (mozreview-request)
(Assignee)

Comment 21

2 years ago
It turns out that the transitionend event isn't reliable in some cases, but the _fullyOpen attribute appears to be, according to that last try push. So I'm going to land that.

Comment 22

2 years ago
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c9a4d8de1808
Make sure browser_tabCloseProbes.js waits for tabs to be fully open before closing them. r=mossop
https://hg.mozilla.org/mozilla-central/rev/c9a4d8de1808
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Comment hidden (Intermittent Failures Robot)
Assignee: nobody → mconley
Whiteboard: [stockwell needswork] → [stockwell fixed]
You need to log in before you can comment on or make changes to this bug.