Closed Bug 1349787 Opened 3 years ago Closed 3 years ago

Intermittent browser/base/content/test/tabs/browser_tabCloseProbes.js | Should only be 1 collected value. - 0 == 1 - JS frame :: chrome://mochitests/content/browser/browser/base/content/test/tabs/browser_tabCloseProbes.js :: assertCount :: line 23

Categories

(Firefox :: Tabbed Browser, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 55
Tracking Status
firefox55 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: mconley)

References

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell fixed])

Attachments

(1 file)

This test landed as part of bug 1340842.
Blocks: 1340842
Component: General → Tabbed Browser
Flags: needinfo?(mconley)
Whiteboard: [stockwell needswork]
See Also: → 1353061
See Also: 1353061
Duplicate of this bug: 1353061
Mike, can you take a look at this, thanks!
Finally reached this point in my queue! Will look at this tomorrow.
Flags: needinfo?(mconley)
Comment on attachment 8855808 [details]
Bug 1349787 - Make sure browser_tabCloseProbes.js waits for tabs to be fully open before closing them.

https://reviewboard.mozilla.org/r/127700/#review130482
Attachment #8855808 - Flags: review?(dtownsend) → review+
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/389893c52830
Make sure browser_tabCloseProbes.js waits for tabs to be fully open before closing them. r=mossop
It turns out that the transitionend event isn't reliable in some cases, but the _fullyOpen attribute appears to be, according to that last try push. So I'm going to land that.
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c9a4d8de1808
Make sure browser_tabCloseProbes.js waits for tabs to be fully open before closing them. r=mossop
https://hg.mozilla.org/mozilla-central/rev/c9a4d8de1808
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Assignee: nobody → mconley
Whiteboard: [stockwell needswork] → [stockwell fixed]
You need to log in before you can comment on or make changes to this bug.