1349809 - getElevationRequired janks the parent process by doing IO on the main thread

Status: NEW

(Toolkit :: Application Update, defect, P3)

Description

[Markus Stange [:mstange]]

Here's a profile that shows 250ms of jank on the parent process: https://perfht.ml/2o72U6m

It shows that nsUpdateService.js is walking directories on the main thread and doing blocking main thread IO.

At the very least it should do the IO asynchronously (e.g. using OS.File), better yet the whole directory traversal should happen on a worker thread.

This will mean that the elevationRequired field can no longer be a synchronous getter, it'll need to be asynchronous.

Comment 1

[Markus Stange [:mstange]]

Here's another profile of this happening, this time with 1.7 seconds of jank: https://perfht.ml/2V5wSs9

Comment 2

[Florian Quèze [:florian]]

Here's a profile where it blocked my Firefox startup for more than 3s on a fast macbook: https://share.firefox.dev/3nmz1Ow