Don't show "Never For This Session" option in web notification permission prompts in PBM

VERIFIED FIXED in Firefox 55

Status

()

Firefox
Site Identity and Permission Panels
P1
normal
VERIFIED FIXED
a year ago
a year ago

People

(Reporter: nhnt11, Assigned: nhnt11)

Tracking

Trunk
Firefox 55
Points:
---

Firefox Tracking Flags

(firefox55 verified)

Details

(Whiteboard: [fxprivacy])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
Bug 1341742 added a dropdown for the secondary action of web notification permission prompts, with a "Never" option ("Never For This Session" in private browsing mode). We shouldn't show this in private browsing mode.
Comment hidden (mozreview-request)
(Assignee)

Comment 2

a year ago
Johann, I started adding a test to browser_PermissionUI_prompts.js but it felt pretty messy without refactoring the file, so I  aborted mission banking on what you said in bug 1348257 comment 3 about adding tests for all permission prompts in a separate bug anyway. Let me know if you think that's reasonable.
Assignee: nobody → nhnt11
Status: NEW → ASSIGNED
(Assignee)

Updated

a year ago
Blocks: 1348735
Duplicate of this bug: 1348735

Comment 4

a year ago
mozreview-review
Comment on attachment 8850345 [details]
Bug 1349841 - Don't show "Never For This Session" option in web notification permission prompts in PBM.

https://reviewboard.mozilla.org/r/122978/#review125378

Thanks!

> I  aborted mission banking on what you said in bug 1348257 comment 3 about adding tests for all permission prompts in a separate bug anyway.

Makes sense to me.
Attachment #8850345 - Flags: review?(jhofmann) → review+

Comment 5

a year ago
Pushed by nhnt11@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/7204bd900962
Don't show "Never For This Session" option in web notification permission prompts in PBM. r=johannh

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7204bd900962
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55

Comment 7

a year ago
Build ID: 20170329030240
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0

Verified as fixed on Firefox Nightly 55.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.
Status: RESOLVED → VERIFIED
status-firefox55: fixed → verified
You need to log in before you can comment on or make changes to this bug.