Closed
Bug 1349859
Opened 7 years ago
Closed 7 years ago
Enabling DOM File creation in content process by pref
Categories
(Remote Protocol :: Marionette, defect)
Tracking
(firefox54 wontfix, firefox55 fixed)
RESOLVED
FIXED
mozilla55
People
(Reporter: baku, Assigned: baku)
References
Details
Attachments
(2 files)
1.94 KB,
patch
|
ato
:
review+
|
Details | Diff | Splinter Review |
2.82 KB,
text/plain
|
Details |
No description provided.
Assignee | ||
Comment 1•7 years ago
|
||
Assignee: nobody → amarchesini
Attachment #8850408 -
Flags: review?(ato)
Comment 2•7 years ago
|
||
Given the current situation and the proposed move to geckoinstance.py, we would also need this preference set via geckodriver. Maybe to avoid that Andreas could integrate this move in his patch on bug 1344748?
Comment 3•7 years ago
|
||
For context, I am working on a patch to set a long list of “recommended” automation prefs when the Marionette server starts, because we would like to make it possible to start/stop Marionette at runtime. In the future we want it to be possible to connect an existing instance of Firefox to geckodriver, which means a range of prefs needs to be set then. However, the recommended automation prefs are not in use when testing Firefox on try. For this reason, all necessary prefs to test Firefox also need to be in geckoinstance.py. Your patch looks OK to me. I think we should land this as-is, then I will rebase https://bugzilla.mozilla.org/show_bug.cgi?id=1344748 on top of this and include the pref in the set of recommended automation prefs.
Updated•7 years ago
|
Attachment #8850408 -
Flags: review?(ato) → review+
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/2f432eb76b01 Enabling DOM File creation in content process for marionette tests, r=ato
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2f432eb76b01
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Comment 6•7 years ago
|
||
The fix on bug 1344957 got uplifted to aurora. So we also have to uplift this test-only change.
status-firefox54:
--- → affected
Whiteboard: [checkin-needed-aurora]
Comment 7•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/d9793b0ed9dc
Whiteboard: [checkin-needed-aurora]
Comment 8•7 years ago
|
||
Backed out for making browser_blobFromFile.js permafail. https://treeherder.mozilla.org/logviewer.html#?job_id=87321101&repo=mozilla-aurora https://hg.mozilla.org/releases/mozilla-aurora/rev/26cd6703fbe4
Flags: needinfo?(amarchesini)
Assignee | ||
Comment 9•7 years ago
|
||
Flags: needinfo?(amarchesini)
Comment 10•7 years ago
|
||
Looks like this fell through the cracks 2 months ago, do we still want this change in 54 (now beta)?
Flags: needinfo?(hskupin)
Comment 11•7 years ago
|
||
I think we are fine here given that bug 1344748 landed for 54.0. But let get the final words from Andreas.
Flags: needinfo?(hskupin) → needinfo?(ato)
Comment 12•7 years ago
|
||
(In reply to Julien Cristau [:jcristau] from comment #10) > Looks like this fell through the cracks 2 months ago, do we still want this > change in 54 (now beta)? I think we should be fine. Thanks for staying vigilant!
Flags: needinfo?(ato)
Comment 13•7 years ago
|
||
Thanks all.
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•