Closed Bug 1349859 Opened 3 years ago Closed 3 years ago

Enabling DOM File creation in content process by pref

Categories

(Testing :: Marionette, defect)

Version 3
defect
Not set

Tracking

(firefox54 wontfix, firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox54 --- wontfix
firefox55 --- fixed

People

(Reporter: baku, Assigned: baku)

References

Details

Attachments

(2 files)

No description provided.
Attached patch pref.patchSplinter Review
Assignee: nobody → amarchesini
Attachment #8850408 - Flags: review?(ato)
Given the current situation and the proposed move to geckoinstance.py, we would also need this preference set via geckodriver. Maybe to avoid that Andreas could integrate this move in his patch on bug 1344748?
For context, I am working on a patch to set a long list of “recommended” automation prefs when the Marionette server starts, because we would like to make it possible to start/stop Marionette at runtime.  In the future we want it to be possible to connect an existing instance of Firefox to geckodriver, which means a range of prefs needs to be set then.

However, the recommended automation prefs are not in use when testing Firefox on try.  For this reason, all necessary prefs to test Firefox also need to be in geckoinstance.py.  Your patch looks OK to me.

I think we should land this as-is, then I will rebase https://bugzilla.mozilla.org/show_bug.cgi?id=1344748 on top of this and include the pref in the set of recommended automation prefs.
Attachment #8850408 - Flags: review?(ato) → review+
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2f432eb76b01
Enabling DOM File creation in content process for marionette tests, r=ato
https://hg.mozilla.org/mozilla-central/rev/2f432eb76b01
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
The fix on bug 1344957 got uplifted to aurora. So we also have to uplift this test-only change.
Whiteboard: [checkin-needed-aurora]
Attached file m-a
Flags: needinfo?(amarchesini)
Looks like this fell through the cracks 2 months ago, do we still want this change in 54 (now beta)?
Flags: needinfo?(hskupin)
I think we are fine here given that bug 1344748 landed for 54.0. But let get the final words from Andreas.
Flags: needinfo?(hskupin) → needinfo?(ato)
(In reply to Julien Cristau [:jcristau] from comment #10)
> Looks like this fell through the cracks 2 months ago, do we still want this
> change in 54 (now beta)?

I think we should be fine.  Thanks for staying vigilant!
Flags: needinfo?(ato)
You need to log in before you can comment on or make changes to this bug.