1349875 - Assertion failure: aThebesContext->CurrentOp() == CompositionOp::OP_OVER, at PresShell.cpp:4735

Status: NEW

(Core :: Graphics, defect, P3)

Description

[Carsten Book [:Tomcat]]

Attachment: bughunter stack

Found via topsite Tests on beta to trunk debug builds and reproduced on latest m-c trunk debug build on windows 7

Steps to reproduce:
-> Load http://www.internetretailer.com
---> Assertion failure after a few seconds

[GFX3-]: Surface size too large (exceeds allocation limit)!
[GFX3-]: Surface size too large (exceeds extent limit)!
Crash Annotation GraphicsCriticalError: |[C0][GFX1-]: Failed to allocate a surface due to invalid size (CDT) Size(7121,21185) (t=68.635) [GFX1-]: Failed to allocate a sur
[GFX3-]: Surface size too large (exceeds allocation limit)!
[GFX3-]: Surface size too large (exceeds extent limit)!
Crash Annotation GraphicsCriticalError: |[C0][GFX1-]: Failed to allocate a surface due to invalid size (CDT) Size(7121,21185) (t=68.635) |[C1][GFX1-]: Failed to allocate
ze(7121,21185)
Assertion failure: aThebesContext->CurrentOp() == CompositionOp::OP_OVER, at c:/builds/moz2_slave/m-cen-w32-d-000000000000000000/build/src/layout/base/PresShell.cpp:4735

Comment 1

[Carsten Book [:Tomcat]]

Michael, could you take a look at this assertion failure ? Seems its gfx (not sure about it) so maybe you know who could take a look ?

Comment 2

[Michael Leu[:Lenzak](UTC+8)]

I can reproduce this crash, it seems to be another oversized memory allocation issue.

Since the crash point is related to SVG, I think CJ will know who can take a look into it.

Hi CJ, any thought about this one?

Comment 3

[u459114]

I guess this is because  we setop at this line
http://searchfox.org/mozilla-central/source/gfx/thebes/gfxUtils.cpp#341

I don't have a window build on hand to verify. 
Michael, can you try to remove this line and see whether we will still hit this assertion.

Comment 4

[Michael Leu[:Lenzak](UTC+8)]

Hi CJ, it does fix the crash, should we land it?

Comment 5

[u459114]

Nono...I just said that is why we hit this assertion.
When you hit an assertion, you have several choices. You can either correct the assertion or correct the code which hit that assertion. You may provide a solution and discuss with the developer who check-in relative code.

Comment 6

[Bas Schouten (:bas.schouten)]

I suspect this is due to a patch I landed a long time ago.

Comment 7

[Intermittent Failures Robot]

1 failures in 3801 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 1

Platform breakdown:

• linux64-qr: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1349875&startday=2019-10-07&endday=2019-10-13&tree=all