Closed Bug 1349885 Opened 3 years ago Closed 3 years ago

stylo: Simplify computation of float and position.

Categories

(Core :: CSS Parsing and Computation, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(1 file)

There's no reason they need to be early properties, and Manish was working around that float does indeed depend on writing mode in bug 1341775.

Here's a patch that fixes it properly.
Comment on attachment 8850453 [details]
Bug 1349885: stylo: Simplify computation of float and position.

https://reviewboard.mozilla.org/r/123046/#review125334
Attachment #8850453 - Flags: review+
Comment on attachment 8850453 [details]
Bug 1349885: stylo: Simplify computation of float and position.

https://reviewboard.mozilla.org/r/123046/#review125340
Attachment #8850453 - Flags: review?(cam) → review+
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/249627eaa999
Reftest expectations update. r=emilio
Priority: -- → P1
https://hg.mozilla.org/mozilla-central/rev/249627eaa999
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.